linux-ia64.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Scheiner <frank.scheiner@web.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-ia64@vger.kernel.org, rafael.j.wysocki@intel.com,
	michal.wilczynski@intel.com,
	debian-ia64 <debian-ia64@lists.debian.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: Build regression since v6.6-rc1
Date: Thu, 21 Sep 2023 14:07:36 +0200	[thread overview]
Message-ID: <cc4e2861-32f6-e063-70ec-e47f88e8de14@web.de> (raw)
In-Reply-To: <CAMj1kXGDVWYJMHJay3j8P=EQMMv1cmSLRDoiDBrt1hdvZpOpww@mail.gmail.com>

Hi Ard,

On 21.09.23 13:53, Ard Biesheuvel wrote:
> Hello Frank,
>
> On Thu, 21 Sept 2023 at 10:15, Frank Scheiner <frank.scheiner@web.de> wrote:
>>
>> Dear all,
>>
>> since v6.6-rc1 (actually introduced with [1], specific commit on [2])
>> the kernel build for ia64 fails like that:
>>
>> ```
> ...
>>
>> Could one ([5]) or the other ([6]) please be included in v6.6 (or
>> earlier) to "fix" the build problem for ia64?
>>
>
> Do you mean by "fix" that the proposed fixes are just workarounds and
> not proper fixes?

Not really, or maybe a little... :-)

> I don't think that is the case - the function in
> question does nothing except apply a quirk for one specific x86
> platform.

...look, as I assumed and as you also say, the function is to "apply a
quirk for one specific x86 platform". So wouldn't it be better to make
that call only on x86 and leave ia64 untouched instead of putting a NOP
there?

I already wondered why no other architecture with ACPI failed to build?

Cheers,
Frank

>
> ...
>> [5]:
>> https://lore.kernel.org/lkml/CAJZ5v0hnNK4O_HyinvTp01YxXR7V4vzpMhf85yW9M2=52-O2Fg@mail.gmail.com/
>>
>> [6]:
>> https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=a0334bf78b95532cec54f56b53e8ae1bfe7e1ca1
>
> Either Arnd, Rafael or myself should send a PR to Linus to merge [6]
> as a fix, as it is already queued up in -next for v6.7.
>
> Or perhaps Linus doesn't mind grabbing it from here:
>
> ------------8<--------------
>
> The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d:
>
>    Linux 6.6-rc1 (2023-09-10 16:28:41 -0700)
>
> are available in the Git repository at:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
> tags/fix-ia64-build-for-v6.6
>
> for you to fetch changes up to a0334bf78b95532cec54f56b53e8ae1bfe7e1ca1:
>
>    acpi: Provide ia64 dummy implementation of
> acpi_proc_quirk_mwait_check() (2023-09-11 08:13:17 +0000)
>
> ----------------------------------------------------------------
> Build fix for Itanium/ia64:
>
> - provide dummy implementation of acpi_proc_quirk_mwait_check() which
>    was moved out of generic code into arch/x86, breaking the ia64 build
>
> ----------------------------------------------------------------
> Ard Biesheuvel (1):
>        acpi: Provide ia64 dummy implementation of acpi_proc_quirk_mwait_check()
>
>   arch/ia64/kernel/acpi.c | 4 ++++
>   1 file changed, 4 insertions(+)

  reply	other threads:[~2023-09-21 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 10:14 Build regression since v6.6-rc1 Frank Scheiner
2023-09-21 11:53 ` Ard Biesheuvel
2023-09-21 12:07   ` Frank Scheiner [this message]
2023-09-21 19:42   ` Wysocki, Rafael J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc4e2861-32f6-e063-70ec-e47f88e8de14@web.de \
    --to=frank.scheiner@web.de \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=debian-ia64@lists.debian.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=michal.wilczynski@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).