From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-acpi@vger.kernel.org, James Morse <james.morse@arm.com>,
loongarch@lists.linux.dev, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
jianyong.wu@arm.com, justin.he@arm.com,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Salil Mehta <salil.mehta@huawei.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH RFC v2] cpu-hotplug: provide prototypes for arch CPU registration
Date: Mon, 25 Sep 2023 17:28:36 +0100 [thread overview]
Message-ID: <ZRG1NBNbljy2/LEy@shell.armlinux.org.uk> (raw)
In-Reply-To: <ZQgHUvW8qgyj5Puv@shell.armlinux.org.uk>
On Mon, Sep 18, 2023 at 09:16:18AM +0100, Russell King (Oracle) wrote:
> On Fri, Sep 15, 2023 at 09:09:10PM +0200, Thomas Gleixner wrote:
> > On Thu, Sep 14 2023 at 15:51, Russell King wrote:
> > > Provide common prototypes for arch_register_cpu() and
> > > arch_unregister_cpu(). These are called by acpi_processor.c, with
> > > weak versions, so the prototype for this is already set. It is
> > > generally not necessary for function prototypes to be conditional
> > > on preprocessor macros.
> > >
> > > Some architectures (e.g. Loongarch) are missing the prototype for this,
> > > and rather than add it to Loongarch's asm/cpu.h, lets do the job once
> > > for everyone.
> > >
> > > Since this covers everyone, remove the now unnecessary prototypes in
> > > asm/cpu.h, and we also need to remove the 'static' from one of ia64's
> > > arch_register_cpu() definitions.
> > >
> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > > ---
> > > Spotted during the review of James Morse's patches, I think rather than
> > > adding prototypes for loongarch to its asm/cpu.h, it would make more
> > > sense to provide the prototypes in a non-arch specific header file so
> > > everyone can benefit, rather than having each architecture do its own
> > > thing.
> > >
> > > I'm sending this as RFC as James has yet to comment on my proposal, and
> > > also to a wider audience, and although it makes a little more work for
> > > James (to respin his series) it does mean that his series should get a
> > > little smaller.
> >
> > And it makes tons of sense.
> >
> > > See:
> > > https://lore.kernel.org/r/20230913163823.7880-2-james.morse@arm.com
> > > https://lore.kernel.org/r/20230913163823.7880-4-james.morse@arm.com
> > > https://lore.kernel.org/r/20230913163823.7880-23-james.morse@arm.com
> > >
> > > v2: lets try not fat-fingering vim.
> >
> > Yeah. I wondered how you managed to mangle that :)
> >
> > > arch/ia64/include/asm/cpu.h | 5 -----
> > > arch/ia64/kernel/topology.c | 2 +-
> >
> > That's moot as ia64 is queued for removal :)
>
> Okay, one less thing to worry about. Tomorrow, I'll re-spin without the
> ia64 bits included.
>
> I would really like to hear from James before we think about merging
> this, as it will impact James' patch set and would add a dependency
> for that. I wouldn't want this patch to become a reason to delay
> James' patch set for another kernel cycle.
It's been totally quiet for a week both from James and from Thomas,
I'll send the patch with the ia64 bits dropped.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2023-09-25 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 14:51 [PATCH RFC v2] cpu-hotplug: provide prototypes for arch CPU registration Russell King (Oracle)
2023-09-15 19:09 ` Thomas Gleixner
2023-09-18 8:16 ` Russell King (Oracle)
2023-09-25 16:28 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRG1NBNbljy2/LEy@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jean-philippe@linaro.org \
--cc=jianyong.wu@arm.com \
--cc=justin.he@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=salil.mehta@huawei.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).