From: James Morse <james.morse@arm.com>
To: Sergei Trofimovich <slyich@gmail.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
matoro <matoro_mailinglist_kernel@matoro.tk>,
"Émeric Maschino" <emeric.maschino@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] ia64: Fix build error due to switch case label appearing next to declaration
Date: Wed, 18 Jan 2023 11:44:54 +0000 [thread overview]
Message-ID: <99b295ed-7157-0c95-cafb-9cf8afdf41f2@arm.com> (raw)
In-Reply-To: <20230117193109.5650fd6f@nz>
Hi Sergei,
On 17/01/2023 19:31, Sergei Trofimovich wrote:
> On Tue, 17 Jan 2023 15:16:32 +0000
> James Morse <james.morse@arm.com> wrote:
>
>> Since commit aa06a9bd8533 ("ia64: fix clock_getres(CLOCK_MONOTONIC) to
>> report ITC frequency"), gcc 10.1.0 fails to build ia64 with the gnomic:
>> | ../arch/ia64/kernel/sys_ia64.c: In function 'ia64_clock_getres':
>> | ../arch/ia64/kernel/sys_ia64.c:189:3: error: a label can only be part of a statement and a declaration is not a statement
>> | 189 | s64 tick_ns = DIV_ROUND_UP(NSEC_PER_SEC, local_cpu_data->itc_freq);
>>
>> This line appears immediately after a case label in a switch.
>>
>> Move the declarations out of the case, to the top of the function.
>>
>> Fixes: aa06a9bd8533 ("ia64: fix clock_getres(CLOCK_MONOTONIC) to report ITC frequency")
>> Signed-off-by: James Morse <james.morse@arm.com>
> Out of curiosity what compiler version behaves like that? I think I and
> matoro build-/run-tested it on gcc-12 and maybe gcc-11.
| # ia64-linux-gcc --version
| ia64-linux-gcc (GCC) 10.1.0
| Copyright (C) 2020 Free Software Foundation, Inc.
| This is free software; see the source for copying conditions. There is NO
| warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
The toolchain originally came from https://mirrors.edge.kernel.org/pub/tools/crosstool/
The really odd thing I'm doing is cross compiling for ia64 on arm64 ... but I wouldn't
have thought the toolchain configuration was any different.
> Thank you!
>
> Reviewed-by: Sergei Trofimovich <slyich@gmail.com>
Thanks,
James
next prev parent reply other threads:[~2023-01-18 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 15:16 [PATCH] ia64: Fix build error due to switch case label appearing next to declaration James Morse
2023-01-17 15:44 ` John Paul Adrian Glaubitz
2023-01-17 19:31 ` Sergei Trofimovich
2023-01-18 11:44 ` James Morse [this message]
2023-01-18 0:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99b295ed-7157-0c95-cafb-9cf8afdf41f2@arm.com \
--to=james.morse@arm.com \
--cc=akpm@linux-foundation.org \
--cc=emeric.maschino@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matoro_mailinglist_kernel@matoro.tk \
--cc=slyich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).