From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, arnd@arndb.de, deller@gmx.de
Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-m68k@lists.linux-m68k.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 1/5] fbdev: Avoid file argument in fb_pgprotect()
Date: Fri, 22 Sep 2023 09:40:55 +0200 [thread overview]
Message-ID: <79b3dd76-7b3e-4be2-946a-6f20532f7ff8@suse.de> (raw)
In-Reply-To: <87il85l1d4.fsf@minerva.mail-host-address-is-not-set>
[-- Attachment #1.1: Type: text/plain, Size: 1622 bytes --]
Hi Javier
Am 20.09.23 um 10:01 schrieb Javier Martinez Canillas:
> Thomas Zimmermann <tzimmermann@suse.de> writes:
>
> Hello Thomas,
>
>> Only PowerPC's fb_pgprotect() needs the file argument, although
>> the implementation does not use it. Pass NULL to the internal
>
> Can you please mention the function that's the implementation for
Sure
> PowerPC ? If I'm looking at the code correctly, that function is
> phys_mem_access_prot() defined in the arch/powerpc/mm/mem.c file:
>
> pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
> unsigned long size, pgprot_t vma_prot)
> {
> if (ppc_md.phys_mem_access_prot)
> return ppc_md.phys_mem_access_prot(file, pfn, size, vma_prot);
>
> if (!page_is_ram(pfn))
> vma_prot = pgprot_noncached(vma_prot);
>
> return vma_prot;
> }
>
> and if set, ppc_md.phys_mem_access_prot is pci_phys_mem_access_prot()
> that is defined in the arch/powerpc/kernel/pci-common.c source file:
>
> https://elixir.bootlin.com/linux/v6.6-rc2/source/arch/powerpc/kernel/pci-common.c#L524
Yes, that's correct. The only value for that function pointer appears to
be pci_phys_mem_access_prot()
>
> That function indeed doesn't use the file argument. So your patch looks
> correct to me.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks
Best regards
Thomas
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-09-22 7:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 13:48 [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper Thomas Zimmermann
2023-09-12 13:48 ` [PATCH v4 1/5] fbdev: Avoid file argument in fb_pgprotect() Thomas Zimmermann
2023-09-20 8:01 ` Javier Martinez Canillas
2023-09-22 7:40 ` Thomas Zimmermann [this message]
2023-09-12 13:49 ` [PATCH v4 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer() Thomas Zimmermann
2023-09-13 8:09 ` Geert Uytterhoeven
2023-09-20 8:09 ` Javier Martinez Canillas
2023-09-12 13:49 ` [PATCH v4 3/5] arch/powerpc: Remove trailing whitespaces Thomas Zimmermann
2023-09-13 6:34 ` Philippe Mathieu-Daudé
2023-09-12 13:49 ` [PATCH v4 4/5] arch/powerpc: Remove file parameter from phys_mem_access_prot code Thomas Zimmermann
2023-09-12 13:49 ` [PATCH v4 5/5] arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code Thomas Zimmermann
2023-09-18 7:32 ` [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper Thomas Zimmermann
2023-09-20 15:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b3dd76-7b3e-4be2-946a-6f20532f7ff8@suse.de \
--to=tzimmermann@suse.de \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).