From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de,
javierm@redhat.com, gregkh@linuxfoundation.org,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, x86@kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH 12/18] arch/parisc: Implement fb_is_primary_device() under arch/parisc
Date: Thu, 06 Apr 2023 19:08:33 +0000 [thread overview]
Message-ID: <5921681.lOV4Wx5bFT@eto.sf-tec.de> (raw)
In-Reply-To: <20230405150554.30540-13-tzimmermann@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
Am Mittwoch, 5. April 2023, 17:05:48 CEST schrieb Thomas Zimmermann:
> Move PARISC's implementation of fb_is_primary_device() into the
> architecture directory. This the place of the declaration and
> where other architectures implement this function. No functional
> changes.
> diff --git a/arch/parisc/video/fbdev.c b/arch/parisc/video/fbdev.c
> new file mode 100644
> index 000000000000..4a0ae08fc75b
> --- /dev/null
> +++ b/arch/parisc/video/fbdev.c
> @@ -0,0 +1,27 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2000 Philipp Rumpf <prumpf@tux.org>
> + * Copyright (C) 2001-2020 Helge Deller <deller@gmx.de>
> + * Copyright (C) 2001-2002 Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> + */
> +
> +#include <linux/module.h>
> +
> +#include <asm/fb.h>
> +
> +#include <video/sticore.h>
> +
> +int fb_is_primary_device(struct fb_info *info)
> +{
Looking at this makes me wonder why the argument to all of these functions
isn't const? Not your fault, but could be a candidate for patch #19?
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-04-06 19:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 15:05 [PATCH 00/18] arch: Consolidate <asm/fb.h> Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 01/18] fbdev: Prepare generic architecture helpers Thomas Zimmermann
2023-04-05 15:53 ` Arnd Bergmann
2023-04-05 16:07 ` Daniel Vetter
2023-04-05 18:33 ` Thomas Zimmermann
2023-04-06 14:06 ` Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 02/18] arch/arc: Implement <asm/fb.h> with generic helpers Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 03/18] arch/arm: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 04/18] arch/arm64: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 05/18] arch/ia64: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 06/18] arch/loongarch: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 07/18] arch/m68k: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 08/18] arch/mips: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 09/18] video: Remove trailing whitespaces Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 10/18] video: Move HP PARISC STI core code to shared location Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 11/18] arch/parisc: Remove trailing whitespaces Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 12/18] arch/parisc: Implement fb_is_primary_device() under arch/parisc Thomas Zimmermann
2023-04-06 19:08 ` Rolf Eike Beer [this message]
2023-04-05 15:05 ` [PATCH 13/18] arch/parisc: Implement <asm/fb.h> with generic helpers Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 14/18] arch/powerpc: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 15/18] arch/sh: " Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 16/18] arch/sparc: Implement fb_is_primary_device() in source file Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 17/18] arch/sparc: Implement <asm/fb.h> with generic helpers Thomas Zimmermann
2023-04-05 15:05 ` [PATCH 18/18] arch/x86: " Thomas Zimmermann
2023-04-06 19:06 ` [PATCH 00/18] arch: Consolidate <asm/fb.h> Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5921681.lOV4Wx5bFT@eto.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).