From: "Michal Suchánek" <msuchanek@suse.de>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Eric DeVolder <eric.devolder@oracle.com>,
linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
chenhuacai@kernel.org, geert@linux-m68k.org,
tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com,
deller@gmx.de, ysato@users.sourceforge.jp, dalias@libc.org,
glaubitz@physik.fu-berlin.de, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
peterz@infradead.org, linus.walleij@linaro.org, hpa@zytor.com,
kernel@xen0n.name, ardb@kernel.org, tsi@tuyoix.net,
agordeev@linux.ibm.com, paulmck@kernel.org, bhe@redhat.com,
masahiroy@kernel.org, konrad.wilk@oracle.com,
sebastian.reichel@collabora.com, samitolvanen@google.com,
ojeda@kernel.org, juerg.haefliger@canonical.com,
borntraeger@linux.ibm.com, frederic@kernel.org, arnd@arndb.de,
mhiramat@kernel.org, aou@eecs.berkeley.edu,
keescook@chromium.org, gor@linux.ibm.com,
anshuman.khandual@arm.com, hca@linux.ibm.com, xin3.li@intel.com,
npiggin@gmail.com, rmk+kernel@armlinux.org.uk,
paul.walmsley@sifive.com, boris.ostrovsky@oracle.com,
ziy@nvidia.com, hbathini@linux.ibm.com,
gregkh@linuxfoundation.org, kirill.shutemov@linux.intel.com,
ndesaulniers@google.com, sourabhjain@linux.ibm.com,
palmer@dabbelt.com, svens@linux.ibm.com, tj@kernel.org,
akpm@linux-foundation.org, rppt@kernel.org
Subject: Re: [PATCH v6 02/14] x86/kexec: refactor for kernel/Kconfig.kexec
Date: Tue, 22 Aug 2023 08:32:57 +0200 [thread overview]
Message-ID: <20230822063257.GI8826@kitsune.suse.cz> (raw)
In-Reply-To: <d8ddd4bd-fbc9-dbe9-f5c3-daf8d89aa46d@huawei.com>
Hello,
On Thu, Jul 13, 2023 at 07:13:57PM +0800, Leizhen (ThunderTown) wrote:
>
>
> On 2023/7/13 0:15, Eric DeVolder wrote:
> > The kexec and crash kernel options are provided in the common
> > kernel/Kconfig.kexec. Utilize the common options and provide
> > the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the
> > equivalent set of KEXEC and CRASH options.
> >
> > Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
> > ---
> > arch/x86/Kconfig | 92 ++++++++++--------------------------------------
> > 1 file changed, 19 insertions(+), 73 deletions(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 7422db409770..9767a343f7c2 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -2040,88 +2040,34 @@ config EFI_RUNTIME_MAP
> >
> > source "kernel/Kconfig.hz"
> >
> > -config KEXEC
> > - bool "kexec system call"
> > - select KEXEC_CORE
> > - help
> > - kexec is a system call that implements the ability to shutdown your
> > - current kernel, and to start another kernel. It is like a reboot
> > - but it is independent of the system firmware. And like a reboot
> > - you can start any kernel with it, not just Linux.
> > -
> > - The name comes from the similarity to the exec system call.
> > -
> > - It is an ongoing process to be certain the hardware in a machine
> > - is properly shutdown, so do not be surprised if this code does not
> > - initially work for you. As of this writing the exact hardware
> > - interface is strongly in flux, so no good recommendation can be
> > - made.
> > -
> > -config KEXEC_FILE
> > - bool "kexec file based system call"
> > - select KEXEC_CORE
> > - select HAVE_IMA_KEXEC if IMA
> > - depends on X86_64
> > - depends on CRYPTO=y
> > - depends on CRYPTO_SHA256=y
> > - help
> > - This is new version of kexec system call. This system call is
> > - file based and takes file descriptors as system call argument
> > - for kernel and initramfs as opposed to list of segments as
> > - accepted by previous system call.
> > +config ARCH_SUPPORTS_KEXEC
> > + def_bool y
>
> In v5, Joel Fernandes seems to suggest you change it to the following form:
It's unfortunate that the suggestion did not make it to the mailinglist.
> In arch/Kconfig:
> +config ARCH_SUPPORTS_KEXEC
> + bool
>
> In arch/x86/Kconfig:
> config X86
> ... ...
> + select ARCH_SUPPORTS_KEXEC
>
> In arch/arm64/Kconfig:
> config ARM64
> ... ...
> + select ARCH_SUPPORTS_KEXEC if PM_SLEEP_SMP
Which might work for this case
>
> etc..
>
> You can refer to ARCH_HAS_DEBUG_VIRTUAL.
>
> >
> > -config ARCH_HAS_KEXEC_PURGATORY
> > - def_bool KEXEC_FILE
> > +config ARCH_SUPPORTS_KEXEC_FILE
> > + def_bool X86_64 && CRYPTO && CRYPTO_SHA256
> >
> > -config KEXEC_SIG
> > - bool "Verify kernel signature during kexec_file_load() syscall"
> > +config ARCH_SELECTS_KEXEC_FILE
> > + def_bool y
> > depends on KEXEC_FILE
> > - help
> > + select HAVE_IMA_KEXEC if IMA
but not this case, at least not this trivially.
Than for consistency it looks better to keep as is.
Thanks
Michal
> >
> > - This option makes the kexec_file_load() syscall check for a valid
> > - signature of the kernel image. The image can still be loaded without
> > - a valid signature unless you also enable KEXEC_SIG_FORCE, though if
> > - there's a signature that we can check, then it must be valid.
> > +config ARCH_HAS_KEXEC_PURGATORY
> > + def_bool KEXEC_FILE
> >
> > - In addition to this option, you need to enable signature
> > - verification for the corresponding kernel image type being
> > - loaded in order for this to work.
> > +config ARCH_SUPPORTS_KEXEC_SIG
> > + def_bool y
> >
> > -config KEXEC_SIG_FORCE
> > - bool "Require a valid signature in kexec_file_load() syscall"
> > - depends on KEXEC_SIG
> > - help
> > - This option makes kernel signature verification mandatory for
> > - the kexec_file_load() syscall.
> > +config ARCH_SUPPORTS_KEXEC_SIG_FORCE
> > + def_bool y
> >
> > -config KEXEC_BZIMAGE_VERIFY_SIG
> > - bool "Enable bzImage signature verification support"
> > - depends on KEXEC_SIG
> > - depends on SIGNED_PE_FILE_VERIFICATION
> > - select SYSTEM_TRUSTED_KEYRING
> > - help
> > - Enable bzImage signature verification support.
> > +config ARCH_SUPPORTS_KEXEC_BZIMAGE_VERIFY_SIG
> > + def_bool y
> >
> > -config CRASH_DUMP
> > - bool "kernel crash dumps"
> > - depends on X86_64 || (X86_32 && HIGHMEM)
> > - help
> > - Generate crash dump after being started by kexec.
> > - This should be normally only set in special crash dump kernels
> > - which are loaded in the main kernel with kexec-tools into
> > - a specially reserved region and then later executed after
> > - a crash by kdump/kexec. The crash dump kernel must be compiled
> > - to a memory address not used by the main kernel or BIOS using
> > - PHYSICAL_START, or it must be built as a relocatable image
> > - (CONFIG_RELOCATABLE=y).
> > - For more details see Documentation/admin-guide/kdump/kdump.rst
> > +config ARCH_SUPPORTS_KEXEC_JUMP
> > + def_bool y
> >
> > -config KEXEC_JUMP
> > - bool "kexec jump"
> > - depends on KEXEC && HIBERNATION
> > - help
> > - Jump between original kernel and kexeced kernel and invoke
> > - code in physical address mode via KEXEC
> > +config ARCH_SUPPORTS_CRASH_DUMP
> > + def_bool X86_64 || (X86_32 && HIGHMEM)
> >
> > config PHYSICAL_START
> > hex "Physical address where the kernel is loaded" if (EXPERT || CRASH_DUMP)
> >
>
> --
> Regards,
> Zhen Lei
next prev parent reply other threads:[~2023-08-22 6:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 16:15 [PATCH v6 00/14] refactor Kconfig to consolidate KEXEC and CRASH options Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 01/14] kexec: consolidate kexec and crash options into kernel/Kconfig.kexec Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 02/14] x86/kexec: refactor for kernel/Kconfig.kexec Eric DeVolder
2023-07-13 11:13 ` Leizhen (ThunderTown)
2023-08-22 6:32 ` Michal Suchánek [this message]
2023-07-12 16:15 ` [PATCH v6 03/14] arm/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 04/14] ia64/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 05/14] arm64/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 06/14] loongarch/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 07/14] m68k/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 08/14] mips/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 09/14] parisc/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 10/14] powerpc/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 11/14] riscv/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 12/14] s390/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 13/14] sh/kexec: " Eric DeVolder
2023-07-12 16:15 ` [PATCH v6 14/14] kexec: rename ARCH_HAS_KEXEC_PURGATORY Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822063257.GI8826@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=eric.devolder@oracle.com \
--cc=frederic@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=juerg.haefliger@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel@xen0n.name \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=sebastian.reichel@collabora.com \
--cc=sourabhjain@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=tj@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=tsi@tuyoix.net \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
--cc=ysato@users.sourceforge.jp \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).