From: Nadav Amit <nadav.amit@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-um@lists.infradead.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, Andy Lutomirski <luto@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Nadav Amit <namit@vmware.com>
Subject: [PATCH 3/3] compiler: inline does not imply notrace
Date: Tue, 22 Nov 2022 19:53:29 +0000 [thread overview]
Message-ID: <20221122195329.252654-4-namit@vmware.com> (raw)
In-Reply-To: <20221122195329.252654-1-namit@vmware.com>
From: Nadav Amit <namit@vmware.com>
Functions that are marked as "inline" are currently also not tracable.
Apparently, this has been done to prevent differences between different
configs that caused different functions to be tracable on different
platforms.
Anyhow, this consideration is not very strong, and tying "inline" and
"notrace" does not seem very beneficial. The "inline" keyword is just a
hint, and many functions are currently not tracable due to this reason.
Disconnect "inline" from "notrace".
Signed-off-by: Nadav Amit <namit@vmware.com>
---
include/linux/compiler_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h
index eb0466236661..36a99ef03a1a 100644
--- a/include/linux/compiler_types.h
+++ b/include/linux/compiler_types.h
@@ -158,7 +158,7 @@ struct ftrace_likely_data {
* of extern inline functions at link time.
* A lot of inline functions can cause havoc with function tracing.
*/
-#define inline inline __gnu_inline __inline_maybe_unused notrace
+#define inline inline __gnu_inline __inline_maybe_unused
/*
* gcc provides both __inline__ and __inline as alternate spellings of
--
2.25.1
next prev parent reply other threads:[~2022-11-22 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 19:53 [PATCH 0/3] kprobes: notrace enhancements Nadav Amit
2022-11-22 19:53 ` [PATCH 1/3] kprobes: Mark descendents of core_kernel_text as notrace Nadav Amit
2022-11-22 19:53 ` [PATCH 2/3] lib/usercopy: Allow traceing of usercopy, xarray, iov_iter Nadav Amit
2022-11-22 19:53 ` Nadav Amit [this message]
2022-11-22 20:09 ` [PATCH 3/3] compiler: inline does not imply notrace Arnd Bergmann
2022-11-22 20:28 ` Steven Rostedt
2022-11-22 20:51 ` Nadav Amit
2022-11-29 2:36 ` Nadav Amit
2022-11-29 4:15 ` Steven Rostedt
2022-11-29 4:25 ` Nadav Amit
2022-11-29 15:06 ` Steven Rostedt
2022-11-29 17:56 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122195329.252654-4-namit@vmware.com \
--to=nadav.amit@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-um@lists.infradead.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).