From: Sergei Trofimovich <slyich@gmail.com>
To: yexingchen116@gmail.com
Cc: akpm@linux-foundation.org, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org,
ye xingchen <ye.xingchen@zte.com.cn>
Subject: Re: [PATCH linux-next] ia64: Replace IS_ERR() with IS_ERR_VALUE()
Date: Thu, 20 Oct 2022 18:56:11 +0000 [thread overview]
Message-ID: <20221020195611.234ca44e@nz> (raw)
In-Reply-To: <20221020113004.400031-1-ye.xingchen@zte.com.cn>
On Thu, 20 Oct 2022 11:30:04 +0000
yexingchen116@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Avoid type casts that are needed for IS_ERR() and use
> IS_ERR_VALUE() instead.
Looks good to me!
Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> arch/ia64/kernel/sys_ia64.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/ia64/kernel/sys_ia64.c b/arch/ia64/kernel/sys_ia64.c
> index 215bf3f8cb20..f6a502e8f02c 100644
> --- a/arch/ia64/kernel/sys_ia64.c
> +++ b/arch/ia64/kernel/sys_ia64.c
> @@ -140,7 +140,7 @@ asmlinkage unsigned long
> sys_mmap2 (unsigned long addr, unsigned long len, int prot, int flags, int fd, long pgoff)
> {
> addr = ksys_mmap_pgoff(addr, len, prot, flags, fd, pgoff);
> - if (!IS_ERR((void *) addr))
> + if (!IS_ERR_VALUE(addr))
> force_successful_syscall_return();
> return addr;
> }
> @@ -152,7 +152,7 @@ sys_mmap (unsigned long addr, unsigned long len, int prot, int flags, int fd, lo
> return -EINVAL;
>
> addr = ksys_mmap_pgoff(addr, len, prot, flags, fd, off >> PAGE_SHIFT);
> - if (!IS_ERR((void *) addr))
> + if (!IS_ERR_VALUE(addr))
> force_successful_syscall_return();
> return addr;
> }
> @@ -162,7 +162,7 @@ ia64_mremap (unsigned long addr, unsigned long old_len, unsigned long new_len, u
> unsigned long new_addr)
> {
> addr = sys_mremap(addr, old_len, new_len, flags, new_addr);
> - if (!IS_ERR((void *) addr))
> + if (!IS_ERR_VALUE(addr))
> force_successful_syscall_return();
> return addr;
> }
> --
> 2.25.1
>
--
Sergei
prev parent reply other threads:[~2022-10-20 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 11:30 [PATCH linux-next] ia64: Replace IS_ERR() with IS_ERR_VALUE() yexingchen116
2022-10-20 18:56 ` Sergei Trofimovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020195611.234ca44e@nz \
--to=slyich@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yexingchen116@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).