From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Tom Rix <trix@redhat.com>, alexandre.belloni@bootlin.com
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i3c: ast2600: set variable ast2600_i3c_ops storage-class-specifier to static
Date: Sun, 30 Apr 2023 10:48:19 +0800 [thread overview]
Message-ID: <71e6b0d439cf53d9b8824370a52a5bed9ce4fcf9.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20230429134601.2688558-1-trix@redhat.com>
Hi Tom,
> smatch reports
> drivers/i3c/master/ast2600-i3c-master.c:121:34: warning: symbol
> 'ast2600_i3c_ops' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be
> static.
Super, thanks!
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
Cheers,
Jeremy
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-04-30 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 13:46 [PATCH] i3c: ast2600: set variable ast2600_i3c_ops storage-class-specifier to static Tom Rix
2023-04-30 2:48 ` Jeremy Kerr [this message]
2023-04-30 21:51 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71e6b0d439cf53d9b8824370a52a5bed9ce4fcf9.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).