From: Nicolas Pitre <npitre@baylibre.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-i3c@lists.infradead.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: correct the config reference for endianness
Date: Mon, 3 Jan 2022 12:03:18 -0500 (EST) [thread overview]
Message-ID: <3p9691n5-3qs-7s3q-pp9-389621935prr@onlyvoer.pbz> (raw)
In-Reply-To: <20220103094504.3602-1-lukas.bulwahn@gmail.com>
On Mon, 3 Jan 2022, Lukas Bulwahn wrote:
> The referred config BIG_ENDIAN does not exist. The config for the
> endianness of the CPU architecture is called CPU_BIG_ENDIAN.
>
> Correct the config name to the existing config for the endianness.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
> ---
> drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 1b73647cc3b1..8c01123dc4ed 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -662,7 +662,7 @@ static int i3c_hci_init(struct i3c_hci *hci)
>
> /* Make sure our data ordering fits the host's */
> regval = reg_read(HC_CONTROL);
> - if (IS_ENABLED(CONFIG_BIG_ENDIAN)) {
> + if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) {
> if (!(regval & HC_CONTROL_DATA_BIG_ENDIAN)) {
> regval |= HC_CONTROL_DATA_BIG_ENDIAN;
> reg_write(HC_CONTROL, regval);
> --
> 2.17.1
>
>
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2022-01-03 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 9:45 [PATCH] i3c/master/mipi-i3c-hci: correct the config reference for endianness Lukas Bulwahn
2022-01-03 17:03 ` Nicolas Pitre [this message]
2022-01-05 8:55 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3p9691n5-3qs-7s3q-pp9-389621935prr@onlyvoer.pbz \
--to=npitre@baylibre.com \
--cc=alexandre.belloni@bootlin.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).