From: Jeremy Kerr <jk@codeconstruct.com.au>
To: "Zbigniew, Lukwinski" <zbigniew.lukwinski@linux.intel.com>,
linux-i3c@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Matt Johnston <matt@codeconstruct.com.au>,
Vitor Soares <ivitro@gmail.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jack Chen <zenghuchen@google.com>,
Billy Tsai <billy_tsai@aspeedtech.com>,
Dylan Hung <dylan_hung@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH v3 3/3] i3c: ast2600: Add AST2600 platform-specific driver
Date: Fri, 28 Apr 2023 07:58:50 +0800 [thread overview]
Message-ID: <25ee56f181b11baa9ef54f13b6ef37977ee48b68.camel@codeconstruct.com.au> (raw)
In-Reply-To: <671a4bc0-526e-5224-7cb9-f80ebab2c0ef@linux.intel.com>
Hi Lukwinski,
> > + case 545:
> > + reg = AST2600_I3CG_REG0_SDA_PULLUP_EN_2K |
> > + AST2600_I3CG_REG0_SDA_PULLUP_EN_750;
>
> It does not work. To enable PullUp=545R you need to set both 28 and
> 29 bit (0x30000000) but 'AST2600_I3CG_REG0_SDA_PULLUP_EN_2K |
> AST2600_I3CG_REG0_SDA_PULLUP_EN_750' is in fact 0x20000000.
Ah, good catch - I'd missed that the 2K is 0b00.
> Maybe you could consider adding extra macro
> 'AST2600_I3CG_REG0_SDA_PULLUP_EN_545' = (0x3 << 28)?
Sounds good, I'll send a fix today.
Cheers,
Jeremy
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-04-27 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 9:14 [PATCH v3 0/3] i3c dw,ast2600: Add a driver for the AST2600 i3c controller Jeremy Kerr
2023-03-31 9:14 ` [PATCH v3 1/3] i3c: dw: Add infrastructure for platform-specific implementations Jeremy Kerr
2023-03-31 9:15 ` [PATCH v3 2/3] dt-bindings: i3c: Add AST2600 i3c controller Jeremy Kerr
2023-03-31 9:15 ` [PATCH v3 3/3] i3c: ast2600: Add AST2600 platform-specific driver Jeremy Kerr
[not found] ` <671a4bc0-526e-5224-7cb9-f80ebab2c0ef@linux.intel.com>
2023-04-27 23:58 ` Jeremy Kerr [this message]
2023-04-05 1:52 ` [PATCH v3 0/3] i3c dw,ast2600: Add a driver for the AST2600 i3c controller Joel Stanley
2023-04-05 4:34 ` Jeremy Kerr
2023-04-05 4:56 ` Joel Stanley
2023-04-05 5:15 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ee56f181b11baa9ef54f13b6ef37977ee48b68.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=ivitro@gmail.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i3c@lists.infradead.org \
--cc=matt@codeconstruct.com.au \
--cc=robh+dt@kernel.org \
--cc=zbigniew.lukwinski@linux.intel.com \
--cc=zenghuchen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).