From: Andi Shyti <andi.shyti@kernel.org>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: i801: Fix a refactoring that broke a touchpad on Lenovo P1
Date: Thu, 21 Mar 2024 21:41:59 +0100 [thread overview]
Message-ID: <hanmsf4vklzy6u2a3bcqiqjwnjimwfxuk64vte6h5avjtowku4@wvcmu3ifb7bo> (raw)
In-Reply-To: <20240321141919.26844-1-mlevitsk@redhat.com>
Hi Maxim,
On Thu, Mar 21, 2024 at 10:19:19AM -0400, Maxim Levitsky wrote:
> Commit 857cc04cdf50 ("i2c: i801: Add helper i801_get_block_len")
> introduced a slight functional change: the status variable is now
> overwritten with the length of an SMBUS tranasaction,
> even in case of success.
>
> This breaks the touchpad on at least my Lenovo P1:
>
> rmi4_physical rmi4-00: Read PDT entry at 0x00e9 failed, code: -6.
> rmi4_physical rmi4-00: RMI initial reset failed! Continuing in spite of this.
> rmi4_physical rmi4-00: Read PDT entry at 0x00e9 failed, code: -6.
> rmi4_physical rmi4-00: IRQ counting failed with code -6.
>
> Fixes: 857cc04cdf50 ("i2c: i801: Add helper i801_get_block_len")
>
next time please drop this blank line here.
Applied to i2c/i2c-host-fixes on
git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
Thank you,
Andi
Patches applied
===============
[1/1] i2c: i801: Fix a refactoring that broke a touchpad on Lenovo P1
commit: a5894bc48f64caa86dbea1744d067c925303c5fc
prev parent reply other threads:[~2024-03-21 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 14:19 [PATCH] i2c: i801: Fix a refactoring that broke a touchpad on Lenovo P1 Maxim Levitsky
2024-03-21 16:11 ` Heiner Kallweit
2024-03-21 20:41 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=hanmsf4vklzy6u2a3bcqiqjwnjimwfxuk64vte6h5avjtowku4@wvcmu3ifb7bo \
--to=andi.shyti@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).