From: Dan Carpenter <dan.carpenter@linaro.org>
To: Robert Marko <robimarko@gmail.com>
Cc: Hanna Hawa <hhhawa@amazon.com>,
andriy.shevchenko@linux.intel.com, wsa@kernel.org,
linus.walleij@linaro.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com,
talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
farbere@amazon.com, itamark@amazon.com
Subject: Re: [PATCH v5 2/2] i2c: Set i2c pinctrl recovery info from it's device pinctrl
Date: Mon, 15 Apr 2024 16:43:25 +0300 [thread overview]
Message-ID: <f7069e5b-0678-4f78-b06e-dba16c5e6088@moroto.mountain> (raw)
In-Reply-To: <CAOX2RU6YOBBgEuwdp8P0GTJ5vB0M5Cbqf5SnVJ9Jbou9w5405g@mail.gmail.com>
On Sun, Apr 14, 2024 at 07:47:50PM +0200, Robert Marko wrote:
> > > > @@ -282,7 +283,9 @@ static void i2c_gpio_init_pinctrl_recovery(struct i2c_adapter *adap)
> > > > {
> > > > struct i2c_bus_recovery_info *bri = adap->bus_recovery_info;
> > > > struct device *dev = &adap->dev;
> > > > - struct pinctrl *p = bri->pinctrl;
> > > > + struct pinctrl *p = bri->pinctrl ?: dev_pinctrl(dev->parent);
> > > > +
> > > > + bri->pinctrl = p;
> > >
> > > Hi Hanna,
> > > I know this has already been merged, but setting bri->pinctrl breaks PXA
> > > recovery.
> >
> > This is patch is a year and half old so it's a bit late to just revert
> > it...
>
> Hi there,
> I know it's old but I just tried it on 6.6 in OpenWrt.
>
> >
> > What does "breaks" mean in this context? Is there a NULL dereference?
> > Do you have a stack trace? It's really hard to get inspired to look at
> > the code when the bug report is so vague...
>
> I admit that I did not explain this properly, but if bri->pinctrl is set then
> PXA I2C is completely broken as in it doesn't work at all, there are no errors
> other than trying to probe for I2C devices will time out.
> We had the same symptoms when PXA was converted to generic I2C recovery and that
> had to be reverted.
>
> I think its probably some pinctrl issue but nobody has been able to
> track it down.
If you wanted you could try the following patch with the change to
i2c_gpio_init_pinctrl_recovery() and without it. (It won't fix anything
it only prints information to dmesg).
regards,
dan carpenter
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 888ca636f3f3..f9477089b980 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -34,6 +34,7 @@
#include <linux/platform_data/i2c-pxa.h>
#include <linux/property.h>
#include <linux/slab.h>
+#include "../../pinctrl/core.h"
/* I2C register field definitions */
#define IBMR_SDAS (1 << 0)
@@ -1345,6 +1346,12 @@ static int i2c_pxa_init_recovery(struct pxa_i2c *i2c)
return 0;
i2c->pinctrl = devm_pinctrl_get(dev);
+ if (IS_ERR(i2c->pinctrl))
+ dev_info(dev, "i2c->pinctrl: %pe\n", i2c->pinctrl);
+ else
+ dev_info(dev, "i2c->pinctrl: %s %s\n",
+ dev_driver_string(i2c->pinctrl->dev),
+ dev_name(i2c->pinctrl->dev));
if (PTR_ERR(i2c->pinctrl) == -ENODEV)
i2c->pinctrl = NULL;
if (IS_ERR(i2c->pinctrl))
prev parent reply other threads:[~2024-04-15 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 16:48 [PATCH v5 0/2] i2c: Set i2c pinctrl recovery info from it's device pinctrl Hanna Hawa
2022-12-28 16:48 ` [PATCH v5 1/2] pinctrl: Add an API to get the pinctrl pins if initialized Hanna Hawa
2022-12-29 0:25 ` Linus Walleij
2023-01-20 8:52 ` Wolfram Sang
2022-12-28 16:48 ` [PATCH v5 2/2] i2c: Set i2c pinctrl recovery info from it's device pinctrl Hanna Hawa
2023-01-20 8:53 ` Wolfram Sang
2024-04-11 17:08 ` Robert Marko
2024-04-14 10:34 ` Dan Carpenter
2024-04-14 17:47 ` Robert Marko
2024-04-15 13:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7069e5b-0678-4f78-b06e-dba16c5e6088@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robimarko@gmail.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).