From: Andi Shyti <andi.shyti@kernel.org>
To: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michal Simek <michal.simek@amd.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v2] i2c: cadence: Avoid fifo clear after start
Date: Fri, 3 May 2024 20:46:26 +0200 [thread overview]
Message-ID: <c6knga4tuouxir67pzisf64oxfhcy53utunvxz53sbfg2zxfva@cj3r26sfudzb> (raw)
In-Reply-To: <20240503094208.296834-1-sai.pavan.boddu@amd.com>
Hi Sai Pavan,
On Fri, May 03, 2024 at 03:12:08PM +0530, Sai Pavan Boddu wrote:
> The Driver unintentionally programs ctrl reg to clear the fifo, which
> happens after the start of transaction. Previously, this was not an issue
> as it involved read-modified-write. However, this issue breaks i2c reads
> on QEMU, as i2c-read is executed before guest starts programming control
> register.
>
> Fixes: ff0cf7bca630 ("i2c: cadence: Remove unnecessary register reads")
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>
pushed to i2c/i2c-host-fixes.
I will send it for pull request next week as this week is already
too late and I want to see a few rounds of tests before asking
Wolfram to take it.
Thanks,
Andi
prev parent reply other threads:[~2024-05-03 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 9:42 [PATCH v2] i2c: cadence: Avoid fifo clear after start Sai Pavan Boddu
2024-05-03 18:46 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6knga4tuouxir67pzisf64oxfhcy53utunvxz53sbfg2zxfva@cj3r26sfudzb \
--to=andi.shyti@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=sai.pavan.boddu@amd.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).