From: Heiner Kallweit <hkallweit1@gmail.com>
To: Corey Minyard <minyard@acm.org>, Wolfram Sang <wsa@kernel.org>
Cc: openipmi-developer@lists.sourceforge.net,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list
Date: Sat, 2 Mar 2024 18:47:12 +0100 [thread overview]
Message-ID: <c2128de2-9ab9-4f47-9783-99e959e11920@gmail.com> (raw)
In-Reply-To: <18568237-0b57-4b74-86ec-a6c358a4e058@gmail.com>
On 27.01.2024 16:15, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
>
Any feedback here? Should this better go through the I2C tree?
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/char/ipmi/ipmi_ipmb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c
> index 4e335832f..9e5c6d682 100644
> --- a/drivers/char/ipmi/ipmi_ipmb.c
> +++ b/drivers/char/ipmi/ipmi_ipmb.c
> @@ -567,7 +567,6 @@ static const struct i2c_device_id ipmi_ipmb_id[] = {
> MODULE_DEVICE_TABLE(i2c, ipmi_ipmb_id);
>
> static struct i2c_driver ipmi_ipmb_driver = {
> - .class = I2C_CLASS_HWMON,
> .driver = {
> .name = DEVICE_NAME,
> .of_match_table = of_ipmi_ipmb_match,
prev parent reply other threads:[~2024-03-02 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 15:15 [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
2024-02-03 20:37 ` Wolfram Sang
2024-03-02 17:47 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2128de2-9ab9-4f47-9783-99e959e11920@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).