From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>, Jean Delvare <jdelvare@suse.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: i801: Fix missing Kconfig dependency
Date: Thu, 4 Apr 2024 20:39:48 +0200 [thread overview]
Message-ID: <53e1238c-0732-4e13-b713-e724e12691c7@gmail.com> (raw)
In-Reply-To: <c5eb2644-8c05-47a5-84ef-07f8ef750e1a@gmail.com>
On 04.04.2024 17:21, Heiner Kallweit wrote:
> The original change adds usage of i2c_root_adapter(), which is
> implemented in i2c-mux.c. So we need I2C_MUX to avoid a linker error.
>
> Fixes: 71b494e043d2 ("i2c: i801: Call i2c_register_spd for muxed child segments")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404042206.MjAQC32x-lkp@intel.com/
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 97989c914..201c5fc17 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -111,6 +111,7 @@ config I2C_I801
> select P2SB if X86
> select CHECK_SIGNATURE if X86 && DMI
> select I2C_SMBUS
> + select I2C_MUX
> help
> If you say yes to this option, support will be included for the Intel
> 801 family of mainboard I2C interfaces. Specifically, the following
Please disregard, I'll send an improved version shortly.
Issue with this version is that I2C_MUX may be enabled even if I2C_MUX_GPIO is
unset and the mux part is disabled.
prev parent reply other threads:[~2024-04-04 18:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 15:21 [PATCH] i2c: i801: Fix missing Kconfig dependency Heiner Kallweit
2024-04-04 18:39 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53e1238c-0732-4e13-b713-e724e12691c7@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).