From: Jochen Friedrich <jochen@scram.de>
To: Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/64] i2c: cpm: reword according to newest specification
Date: Fri, 12 Apr 2024 08:32:48 +0200 [thread overview]
Message-ID: <2271dcf2-83c3-4570-87f5-c483faa2f9cd@scram.de> (raw)
In-Reply-To: <26y3smrxv3q56peuqatospr3q6annxvdmleyhykyrjrovne6mu@yg44mmr7aaqp>
>>>> out_8(&cpm->i2c_reg->i2mod, 0x00);
>>>> - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */
>>>> + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */
>>> I2COM_MASTER might be coming from the datasheet.
>> Maybe we can just drop the comment? The value we write is pretty
>> self-explaining.
> indeed.
>
> Andi
I also agree. You might add my Acked-By: <jochen@scram.de> here. Jochen
next prev parent reply other threads:[~2024-04-12 6:47 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 13:24 [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification Wolfram Sang
2024-03-22 13:24 ` [PATCH 01/64] " Wolfram Sang
2024-03-23 9:47 ` Andi Shyti
2024-04-08 8:27 ` Wolfram Sang
2024-03-22 13:24 ` [PATCH 02/64] i2c: ali15x3: reword " Wolfram Sang
2024-03-25 23:46 ` Andi Shyti
2024-03-22 13:24 ` [PATCH 03/64] i2c: altera: " Wolfram Sang
2024-03-26 0:12 ` Andi Shyti
2024-03-22 13:24 ` [PATCH 04/64] i2c: amd-mp2-pci: " Wolfram Sang
2024-03-26 0:14 ` Andi Shyti
2024-03-22 13:24 ` [PATCH 05/64] i2c: aspeed: " Wolfram Sang
2024-03-25 2:29 ` Andrew Jeffery
2024-03-26 0:17 ` Andi Shyti
2024-04-08 8:35 ` Wolfram Sang
2024-03-22 13:24 ` [PATCH 06/64] i2c: au1550: " Wolfram Sang
2024-03-26 7:27 ` Andi Shyti
2024-04-08 8:49 ` Wolfram Sang
2024-03-22 13:25 ` [PATCH 07/64] i2c: bcm-iproc: " Wolfram Sang
2024-03-26 7:29 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 08/64] i2c: bcm-kona: " Wolfram Sang
2024-03-26 7:39 ` Andi Shyti
2024-03-26 12:43 ` Florian Fainelli
2024-03-22 13:25 ` [PATCH 09/64] i2c: bcm2835: " Wolfram Sang
2024-03-26 12:44 ` Florian Fainelli
2024-03-26 19:03 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 10/64] i2c: brcmstb: " Wolfram Sang
2024-03-26 12:44 ` Florian Fainelli
2024-03-26 19:04 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 11/64] i2c: cadence: " Wolfram Sang
2024-03-26 19:06 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 12/64] i2c: cht-wc: " Wolfram Sang
2024-03-26 19:06 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 13/64] i2c: cp2615: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 14/64] i2c: cpm: " Wolfram Sang
2024-03-26 19:09 ` Andi Shyti
2024-04-08 9:04 ` Wolfram Sang
2024-04-10 15:25 ` Andi Shyti
2024-04-12 6:32 ` Jochen Friedrich [this message]
2024-03-22 13:25 ` [PATCH 15/64] i2c: davinci: " Wolfram Sang
2024-03-25 15:07 ` Bartosz Golaszewski
2024-03-22 13:25 ` [PATCH 16/64] i2c: digicolor: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 17/64] i2c: dln2: " Wolfram Sang
2024-03-26 19:16 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 18/64] i2c: eg20t: " Wolfram Sang
2024-03-26 19:18 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 19/64] i2c: emev2: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 20/64] i2c: fsi: " Wolfram Sang
2024-03-26 20:08 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 21/64] i2c: gpio: " Wolfram Sang
2024-03-27 20:44 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 22/64] i2c: highlander: " Wolfram Sang
2024-03-27 21:02 ` Andi Shyti
2024-04-08 9:07 ` Wolfram Sang
2024-04-10 15:19 ` Andi Shyti
2024-03-22 13:25 ` [PATCH 23/64] i2c: hix5hd2: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 24/64] i2c: i801: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 25/64] i2c: ibm_iic: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 26/64] i2c: imx-lpi2c: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 27/64] i2c: iop3xx: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 28/64] i2c: isch: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 29/64] i2c: ismt: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 30/64] i2c: ljca: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 31/64] i2c: lpc2k: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 32/64] i2c: ls2x: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 33/64] i2c: mchp-pci1xxxx: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 34/64] i2c: microchip-corei2c: " Wolfram Sang
2024-03-25 19:14 ` Conor Dooley
2024-03-22 13:25 ` [PATCH 35/64] i2c: mlxcpld: " Wolfram Sang
2024-03-22 22:28 ` Vadim Pasternak
2024-03-22 13:25 ` [PATCH 36/64] i2c: mpc: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 37/64] i2c: mt7621: " Wolfram Sang
2024-03-25 8:06 ` AngeloGioacchino Del Regno
2024-03-25 8:07 ` Stefan Roese
2024-03-22 13:25 ` [PATCH 38/64] i2c: mv64xxx: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 39/64] i2c: octeon-core: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 40/64] i2c: owl: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 41/64] i2c: piix4: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 42/64] i2c: powermac: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 43/64] i2c: pxa-pci: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 44/64] i2c: qup: " Wolfram Sang
2024-03-22 14:35 ` Bjorn Andersson
2024-03-22 13:25 ` [PATCH 45/64] i2c: rcar: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 46/64] i2c: riic: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 47/64] i2c: rk3x: " Wolfram Sang
2024-03-22 13:51 ` Heiko Stübner
2024-03-22 13:25 ` [PATCH 48/64] i2c: sh7760: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 49/64] i2c: sh_mobile: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 50/64] i2c: sis5595: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 51/64] i2c: sis630: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 52/64] i2c: sprd: " Wolfram Sang
2024-03-25 1:01 ` Baolin Wang
2024-03-22 13:25 ` [PATCH 53/64] i2c: st: " Wolfram Sang
2024-03-22 17:11 ` Easwar Hariharan
2024-04-08 9:14 ` Wolfram Sang
2024-03-22 13:25 ` [PATCH 54/64] i2c: stm32f4: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 55/64] i2c: sun6i-p2wi: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 56/64] i2c: synquacer: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 57/64] i2c: taos-evm: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 58/64] i2c: tiny-usb: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 59/64] i2c: uniphier-f: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 60/64] i2c: uniphier: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 61/64] i2c: viperboard: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 62/64] i2c: xlp9xx: " Wolfram Sang
2024-03-25 3:39 ` George Cherian
2024-03-22 13:25 ` [PATCH 63/64] i2c: scx200_acb: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 64/64] i2c: reword i2c_algorithm in drivers " Wolfram Sang
2024-03-22 14:34 ` Bjorn Andersson
2024-03-22 15:11 ` Nicolas Ferre
2024-03-22 16:47 ` Wolfram Sang
2024-03-22 17:05 ` Guenter Roeck
2024-03-22 17:09 ` Wolfram Sang
2024-03-22 16:09 ` Andy Shevchenko
2024-03-22 16:48 ` Wolfram Sang
2024-03-22 17:00 ` Andy Shevchenko
2024-03-25 7:45 ` Oleksij Rempel
2024-03-25 7:53 ` Jarkko Nikula
2024-04-02 12:35 ` Linus Walleij
2024-03-23 9:20 ` [PATCH 00/64] i2c: reword i2c_algorithm " Andi Shyti
2024-03-26 0:36 ` Andi Shyti
2024-04-05 8:48 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2271dcf2-83c3-4570-87f5-c483faa2f9cd@scram.de \
--to=jochen@scram.de \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).