From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Andi Shyti <andi.shyti@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 01/18] i2c: at91-master: remove printout on handled timeouts
Date: Wed, 10 Apr 2024 13:24:15 +0200 [thread overview]
Message-ID: <20240410112418.6400-21-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>
I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-at91-master.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
index d311981d3e60..ee3b469ddfb9 100644
--- a/drivers/i2c/busses/i2c-at91-master.c
+++ b/drivers/i2c/busses/i2c-at91-master.c
@@ -591,7 +591,6 @@ static int at91_do_twi_transfer(struct at91_twi_dev *dev)
dev->adapter.timeout);
if (time_left == 0) {
dev->transfer_status |= at91_twi_read(dev, AT91_TWI_SR);
- dev_err(dev->dev, "controller timed out\n");
at91_init_twi_bus(dev);
ret = -ETIMEDOUT;
goto error;
--
2.43.0
next prev parent reply other threads:[~2024-04-10 11:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 11:24 [PATCH 00/18] i2c: remove printout on handled timeouts Wolfram Sang
2024-04-10 11:24 ` Wolfram Sang [this message]
2024-04-10 11:24 ` [PATCH 02/18] i2c: bcm-iproc: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 03/18] i2c: bcm2835: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 04/18] i2c: cadence: " Wolfram Sang
2024-04-11 7:09 ` Michal Simek
2024-04-10 11:24 ` [PATCH 05/18] i2c: davinci: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 06/18] i2c: i801: " Wolfram Sang
2024-04-10 12:21 ` Andi Shyti
2024-04-11 7:02 ` Wolfram Sang
2024-04-11 9:16 ` Andi Shyti
2024-04-24 0:11 ` Andy Shevchenko
2024-04-10 11:24 ` [PATCH 07/18] i2c: img-scb: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 08/18] i2c: ismt: " Wolfram Sang
2024-04-24 0:11 ` Andy Shevchenko
2024-04-10 11:24 ` [PATCH 09/18] i2c: nomadik: " Wolfram Sang
2024-04-12 8:39 ` Linus Walleij
2024-04-10 11:24 ` [PATCH 10/18] i2c: omap: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 11/18] i2c: qcom-geni: " Wolfram Sang
2024-04-11 3:07 ` Bjorn Andersson
2024-04-10 11:24 ` [PATCH 12/18] i2c: qup: " Wolfram Sang
2024-04-11 3:08 ` Bjorn Andersson
2024-04-10 11:24 ` [PATCH 13/18] i2c: rk3x: " Wolfram Sang
2024-04-11 18:59 ` Heiko Stuebner
2024-04-12 21:12 ` Dragan Simic
2024-04-13 6:38 ` Wolfram Sang
2024-04-13 6:44 ` Dragan Simic
2024-04-13 7:10 ` Wolfram Sang
2024-04-13 8:07 ` Dragan Simic
2024-04-13 7:58 ` Heiko Stübner
2024-04-13 8:12 ` Dragan Simic
2024-04-13 14:35 ` Wolfram Sang
2024-04-16 19:02 ` Andi Shyti
2024-04-10 11:24 ` [PATCH 14/18] i2c: sh_mobile: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 15/18] i2c: st: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 16/18] i2c: tegra: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 17/18] i2c: uniphier-f: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 18/18] i2c: uniphier: " Wolfram Sang
2024-04-22 22:50 ` [PATCH 00/18] i2c: " Andi Shyti
2024-04-24 0:08 ` Andy Shevchenko
2024-04-24 9:00 ` Wolfram Sang
2024-04-24 12:41 ` Andy Shevchenko
2024-04-24 12:44 ` Andy Shevchenko
2024-04-27 18:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410112418.6400-21-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=codrin.ciubotariu@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).