From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Naveen Krishna Ch <ch.naveen@samsung.com>,
<linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@axis.com>
Subject: Re: [PATCH v2] i2c: exynos5: Init data before registering interrupt handler
Date: Tue, 5 Mar 2024 11:42:26 +0100 [thread overview]
Message-ID: <20240305104226.GW30969@axis.com> (raw)
In-Reply-To: <vk5s2p43v7lmmuwh3mzvgqetu4luwodmkejf4va6xyxwgdn5eq@ej2mjdii3rle>
On Tue, Mar 05, 2024 at 10:53:13AM +0100, Andi Shyti wrote:
> Hi Jesper,
Hi Andi,
> I have taken your patch in my testing branch, but...
>
> > + /* Clear pending interrupts from u-boot or misc causes */
> > + exynos5_i2c_clr_pend_irq(i2c);
> > +
> > + i2c->irq = ret = platform_get_irq(pdev, 0);
>
> ... I get this checkpatch note:
>
> CHECK: multiple assignments should be avoided
> #60: FILE: drivers/i2c/busses/i2c-exynos5.c:932:
> + i2c->irq = ret = platform_get_irq(pdev, 0);
Hm, that's weird, I did run checkpatch and got no notices about that.
Ah, it looks like you're running with --strict to checkpatch.
> You are still in time to fix it, or you can fix it later or you
> can leave it as for me it's not a big deal.
No problem, v3 coming soon.
> But, please, next time, make sure to run checkpatch before
> sending a patch.
Yup. I'll run with --strict also in the future.
> Thanks,
> Andi
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2024-03-05 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:30 [PATCH v2] i2c: exynos5: Init data before registering interrupt handler Jesper Nilsson
2024-03-05 9:53 ` Andi Shyti
2024-03-05 10:42 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305104226.GW30969@axis.com \
--to=jesper.nilsson@axis.com \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).