From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: Alex Ionescu <aionescu@gmail.com>, linux-hyperv@vger.kernel.org
Subject: Re: Incorrect definition of hv_enable_vp_vtl in hyperv-tlfs.h
Date: Thu, 19 Oct 2023 09:18:19 -0700 [thread overview]
Message-ID: <d6e7e256-8267-4202-80e4-5412419bc882@linux.microsoft.com> (raw)
In-Reply-To: <CAJ-90N+sS6tuzMtRLOSan7WMZZ2g1H-iFc1F1ne631d2kgoi_g@mail.gmail.com>
On 10/16/2023 4:49 AM, Alex Ionescu wrote:
> Hi,
>
> In arch/x86/include/asm/hyperv-tlfs.h, the following definition at
> line 786 (in Linus' tree), I believe to be incorrect.
>
> struct hv_enable_vp_vtl {
> u64 partition_id;
> u32 vp_index;
> union hv_input_vtl target_vtl; <==== Here
>
> For this hypercall, the TLFS and MSDN documentation states this field
> is HV_VTL (u8) and not HV_INPUT_VTL (the bit-field used for targeting
> hypercalls to specific target VTLs, which is not the case here).
>
> I realize this is essentially a no-op in code at the moment, but for
> correctness should be addressed? I'm happy to make a patch, but wanted
> to make sure this isn't a mistake in TLFS/MSDN to begin with
> (although, my copy of GDK headers would corroborate it's indeed HV_VTL
> as well).
>
> Best regards,
> Alex Ionescu
Hi Alex,
I checked the code to make sure - seems like the TLFS doc is correct. It
should indeed be HV_VTL (u8).
Feel free to submit a patch.
Thanks
Nuno
prev parent reply other threads:[~2023-10-19 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 11:49 Incorrect definition of hv_enable_vp_vtl in hyperv-tlfs.h Alex Ionescu
2023-10-19 16:18 ` Nuno Das Neves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e7e256-8267-4202-80e4-5412419bc882@linux.microsoft.com \
--to=nunodasneves@linux.microsoft.com \
--cc=aionescu@gmail.com \
--cc=linux-hyperv@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).