From: Wei Liu <wei.liu@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
linux-hyperv@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] hv: vmbus: Convert to platform remove callback returning void
Date: Fri, 8 Mar 2024 23:49:58 +0000 [thread overview]
Message-ID: <ZeukJmEAKtlO7GZ-@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <920230729ddbeb9f3c4ff8282a18b0c0e1a37969.1709886922.git.u.kleine-koenig@pengutronix.de>
On Fri, Mar 08, 2024 at 09:51:08AM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to hyperv-next, thanks!
> ---
> drivers/hv/vmbus_drv.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 7f7965f3d187..4cb17603a828 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -2359,10 +2359,9 @@ static int vmbus_platform_driver_probe(struct platform_device *pdev)
> return vmbus_acpi_add(pdev);
> }
>
> -static int vmbus_platform_driver_remove(struct platform_device *pdev)
> +static void vmbus_platform_driver_remove(struct platform_device *pdev)
> {
> vmbus_mmio_remove();
> - return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> @@ -2542,7 +2541,7 @@ static const struct dev_pm_ops vmbus_bus_pm = {
>
> static struct platform_driver vmbus_platform_driver = {
> .probe = vmbus_platform_driver_probe,
> - .remove = vmbus_platform_driver_remove,
> + .remove_new = vmbus_platform_driver_remove,
> .driver = {
> .name = "vmbus",
> .acpi_match_table = ACPI_PTR(vmbus_acpi_device_ids),
>
> base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
> --
> 2.43.0
>
prev parent reply other threads:[~2024-03-08 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:51 [PATCH] hv: vmbus: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-08 23:49 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeukJmEAKtlO7GZ-@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kernel@pengutronix.de \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).