From: Wei Liu <wei.liu@kernel.org>
To: Michael Kelley <mhklinux@outlook.com>
Cc: Wei Liu <wei.liu@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Markus Elfring <Markus.Elfring@web.de>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Dexuan Cui <decui@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 1/2] Drivers: hv: vmbus: Remove duplication and cleanup code in create_gpadl_header()
Date: Fri, 1 Mar 2024 09:25:57 +0000 [thread overview]
Message-ID: <ZeGfJZv-dWMIZJsx@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <SN6PR02MB4157D586E6523E5747690FB0D44B2@SN6PR02MB4157.namprd02.prod.outlook.com>
On Fri, Feb 09, 2024 at 03:33:24PM +0000, Michael Kelley wrote:
> From: Michael Kelley <mhklinux@outlook.com> Sent: Friday, January 12, 2024 8:19 AM
> >
> > From: Markus Elfring <Markus.Elfring@web.de> Sent: Friday, January 12,
> > 2024 12:06 AM
> > >
> > > …
> > > > Eliminate the duplication by making minor tweaks to the logic and
> > > > associated comments. While here, simplify the handling of memory
> > > > allocation errors, and use umin() instead of open coding it.
> > > …
> > >
> > > I got the impression that the adjustment for the mentioned macro
> > > should be performed in a separate update step of the presented patch series.
> > > https://elixir.bootlin.com/linux/v6.7/source/include/linux/minmax.h#L95
> > >
> > > See also:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu
> > > mentation/process/submitting-patches.rst?h=v6.7#n81
> > >
> >
> > To me, this is a judgment call. Breaking out the umin() change into
> > a separate patch is OK, but for consistency then I should probably
> > break out the change to memory allocation errors in the same
> > way. Then we would have three patches, plus the patch to
> > separately handle the indentation so the changes are reviewable.
> > To me, that's overkill for updates to a single function that have
> > no functionality change. The intent of the patch is to cleanup
> > and simplify a single 13-year old function, and it's OK to do
> > that in a single patch (plus the indentation patch).
> >
> > Wei Liu is the maintainer for the Hyper-V code. Wei -- any
> > objections to keeping a single patch (plus the indentation patch)?
> > But I'll break it out if that's your preference.
> >
>
> Wei Liu -- any input on this? This is just a cleanup/simplification
> patch, so it's not urgent.
These patches are fine. I'll take them via the hyperv-fixes tree.
Thanks,
Wei.
prev parent reply other threads:[~2024-03-01 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 16:54 [PATCH 1/2] Drivers: hv: vmbus: Remove duplication and cleanup code in create_gpadl_header() mhkelley58
2024-01-11 16:54 ` [PATCH 2/2] Drivers: hv: vmbus: Update indentation " mhkelley58
2024-01-12 8:06 ` [PATCH 1/2] Drivers: hv: vmbus: Remove duplication and cleanup code " Markus Elfring
2024-01-12 16:19 ` Michael Kelley
2024-02-09 15:33 ` Michael Kelley
2024-03-01 9:25 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeGfJZv-dWMIZJsx@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@linaro.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).