From: Yury Norov <yury.norov@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Dexuan Cui" <decui@microsoft.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
"Jan Kara" <jack@suse.cz>,
"Mirsad Todorovac" <mirsad.todorovac@alu.unizg.hr>,
"Matthew Wilcox" <willy@infradead.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Maxim Kuvyrkov" <maxim.kuvyrkov@linaro.org>,
"Alexey Klimov" <klimov.linux@gmail.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Michael Kelley" <mhklinux@outlook.com>
Subject: Re: [PATCH v2 14/35] PCI: hv: switch hv_get_dom_num() to use atomic find_bit()
Date: Fri, 8 Dec 2023 10:34:20 -0800 [thread overview]
Message-ID: <ZXNhrHWLu6LydQvp@yury-ThinkPad> (raw)
In-Reply-To: <20231204191427.GA623236@bhelgaas>
On Mon, Dec 04, 2023 at 01:14:27PM -0600, Bjorn Helgaas wrote:
> On Sun, Dec 03, 2023 at 11:32:46AM -0800, Yury Norov wrote:
> > The function traverses bitmap with for_each_clear_bit() just to allocate
> > a bit atomically. We can do it better with a dedicated find_and_set_bit().
>
> No objection from me, but please tweak the subject line to match
> previous hv history, i.e., capitalize the first word after the prefix:
>
> PCI: hv: Use atomic find_and_set_bit()
>
> I think there's value in using similar phrasing across the whole
> series. Some subjects say "optimize xyz()", some say "rework xyz()",
> some "rework xyz()", etc. I think it's more informative to include
> the "atomic" and "find_bit()" ideas in the subject than the specific
> functions that *use* it.
>
> I also like how some of the other commit logs clearly say what the
> patch does, e.g., "Simplify by using dedicated find_and_set_bit()", as
> opposed to just "We can do it better ..." which technically doesn't
> say what the patch does.
>
> Very nice simplification in all these users, thanks for doing it!
>
> I assume you'll merge these all together since they depend on [01/35],
> so:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Thank you Bjorn!
Now as many people asked to move their subsystems patch together with
#1, I think, if no objections, it's simpler to pull all the series in
bitmap-for-next.
I'm going to align commit messages wording, as you suggested, address
some other comments, and will send v3 this weekend.
Thanks,
Yury
next prev parent reply other threads:[~2023-12-08 18:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 19:23 [PATCH v2 00/35] bitops: add atomic find_bit() operations Yury Norov
2023-12-03 19:23 ` [PATCH v2 01/35] lib/find: add atomic find_bit() primitives Yury Norov
2023-12-03 19:32 ` [PATCH v2 02/35] lib/find: add test for atomic find_bit() ops Yury Norov
2023-12-03 19:32 ` [PATCH v2 14/35] PCI: hv: switch hv_get_dom_num() to use atomic find_bit() Yury Norov
2023-12-04 5:58 ` Wei Liu
2023-12-04 19:14 ` Bjorn Helgaas
2023-12-08 18:34 ` Yury Norov [this message]
2023-12-04 13:07 ` [PATCH v2 00/35] bitops: add atomic find_bit() operations Andy Shevchenko
2023-12-04 18:51 ` Jan Kara
2023-12-06 5:22 ` Yury Norov
2023-12-07 9:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXNhrHWLu6LydQvp@yury-ThinkPad \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bvanassche@acm.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=helgaas@kernel.org \
--cc=jack@suse.cz \
--cc=klimov.linux@gmail.com \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lpieralisi@kernel.org \
--cc=maxim.kuvyrkov@linaro.org \
--cc=mhklinux@outlook.com \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=wei.liu@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).