From: Boqun Feng <boqun.feng@gmail.com>
To: Peter Martincic <pmartincic@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
Boqun Feng <Boqun.Feng@microsoft.com>,
Wei Liu <liuwe@microsoft.com>
Subject: Re: [EXTERNAL] Re: [PATCH] hv_utils: Allow implicit ICTIMESYNCFLAG_SYNC
Date: Mon, 6 Nov 2023 11:01:50 -0800 [thread overview]
Message-ID: <ZUk4HveGJyao3h5f@boqun-archlinux> (raw)
In-Reply-To: <CY5PR21MB3660C276E3A8A20167B7644AD5AAA@CY5PR21MB3660.namprd21.prod.outlook.com>
On Mon, Nov 06, 2023 at 06:18:48PM +0000, Peter Martincic wrote:
> Sorry for the formatting/recipient/procedure mistakes. I've an updated commit message based on feedback from Michael. I'll wait to hear back from you and Boqun before I post V2/updates.
>
> Thanks again,
> Peter
>
> -----Original Message-----
> From: Wei Liu <wei.liu@kernel.org>
> Sent: Sunday, November 5, 2023 5:31 PM
> To: Peter Martincic <pmartincic@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org; Michael Kelley (LINUX) <mikelley@microsoft.com>; Boqun Feng <Boqun.Feng@microsoft.com>; Wei Liu <liuwe@microsoft.com>; Wei Liu <wei.liu@kernel.org>
> Subject: [EXTERNAL] Re: [PATCH] hv_utils: Allow implicit ICTIMESYNCFLAG_SYNC
>
> On Fri, Oct 27, 2023 at 08:42:33PM +0000, Peter Martincic wrote:
> > From 529fcea5d296c22b1dc6c23d55bd6417794b3cda Mon Sep 17 00:00:00 2001
> > From: Peter Martincic <pmartincic@microsoft.com>
> > Date: Mon, 16 Oct 2023 16:41:10 -0700
> > Subject: [PATCH] hv_utils: Allow implicit ICTIMESYNCFLAG_SYNC
> >
> > Windows hosts can omit the _SYNC flag to due a bug on resume from
> > modern suspend. If the guest is sufficiently behind, treat a _SAMPLE
> > the same as if _SYNC was received.
> >
> > This is hidden behind param hv_utils.timesync_implicit.
> >
> > Signed-off-by: Peter Martincic <pmartincic@microsoft.com>
>
> Boqun, what do you think about this patch?
>
The patch looks good to me. Peter, feel free to send the V2 and I will
give my Acked-by.
Regards,
Boqun
prev parent reply other threads:[~2023-11-06 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 20:42 [PATCH] hv_utils: Allow implicit ICTIMESYNCFLAG_SYNC Peter Martincic
2023-11-06 1:30 ` Wei Liu
2023-11-06 18:18 ` [EXTERNAL] " Peter Martincic
2023-11-06 19:01 ` Boqun Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUk4HveGJyao3h5f@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=Boqun.Feng@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=pmartincic@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).