From: Michael Kelley <mhklinux@outlook.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"decui@microsoft.com" <decui@microsoft.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH 1/1] Documentation: hyperv: Add overview of PCI pass-thru device support
Date: Thu, 15 Feb 2024 19:04:17 +0000 [thread overview]
Message-ID: <SN6PR02MB4157798C452BD3D01E784CADD44D2@SN6PR02MB4157.namprd02.prod.outlook.com> (raw)
In-Reply-To: <d75a2788-b8dc-46cc-b8ca-a740a1fb74f5@linux.microsoft.com>
From: Easwar Hariharan <eahariha@linux.microsoft.com> Sent: Thursday, February 15, 2024 10:41 AM
>
> On 2/14/2024 3:22 PM, mhkelley58@gmail.com wrote:
> >
> > Add documentation topic for PCI pass-thru devices in Linux guests
> > on Hyper-V and for the associated PCI controller driver (pci-hyperv.c).
> >
> > Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> > ---
[snip]
> > +
> > +With this approach, the vPCI device is a VMBus device and a
> > +PCI device at the same time. In response to the VMBus offer
> > +message, the hv_pci_probe() function runs and establishes a
> > +VMBus connection to the vPCI VSP on the Hyper-V host. That
> > +connection has a single VMBus channel. The channel is used to
> > +exchange messages with the vPCI VSP for the purpose of setting
> > +up and configuring the vPCI device in Linux. Once the device
> > +is fully configured in Linux as a PCI device, the VMBus
> > +channel is used only if Linux changes the vCPU to be
> > +interrupted in the guest, or
>
>
> > ..............................if the vPCI device is removed by
> > +the VM while the VM is running.
>
> This seems to conflict with the statement called out below. Did you
> mean to say "if the vPCI device is removed *from* the VM..."?
>
Oops! Yes, that should be "from the VM".
[snip]
>
> Otherwise, FWIW
>
> Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>
Thanks for reviewing and spotting that error. I'll see what
other comments accumulate and then send out a v2 with
updates.
Michael
prev parent reply other threads:[~2024-02-15 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 23:22 [PATCH 1/1] Documentation: hyperv: Add overview of PCI pass-thru device support mhkelley58
2024-02-15 18:40 ` Easwar Hariharan
2024-02-15 19:04 ` Michael Kelley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR02MB4157798C452BD3D01E784CADD44D2@SN6PR02MB4157.namprd02.prod.outlook.com \
--to=mhklinux@outlook.com \
--cc=corbet@lwn.net \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).