From: Long Li <longli@microsoft.com>
To: Simon Horman <horms@kernel.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Ajay Sharma <sharmaajay@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Patch v1 2/4] RDMA/mana_ib: create and process EQ events
Date: Mon, 27 Nov 2023 19:00:21 +0000 [thread overview]
Message-ID: <PH7PR21MB3263ECFFD2850220F3F55E29CEBDA@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20231126171504.GC84723@kernel.org>
> > @@ -505,14 +507,24 @@ static void mana_gd_deregiser_irq(struct
> gdma_queue *queue)
> > if (WARN_ON(msix_index >= gc->num_msix_usable))
> > return;
> >
> > + spin_lock_irqsave(&r->lock, flags);
> > +
> > gic = &gc->irq_contexts[msix_index];
> > - gic->handler = NULL;
> > - gic->arg = NULL;
> > + list_for_each_rcu(p, &gic->eq_list) {
> > + eq = list_entry(p, struct gdma_queue, entry);
>
> Hi Long Li,
>
> Sparse complains a bit about this construction:
>
> .../gdma_main.c:513:9: error: incompatible types in comparison expression
> (different address spaces):
> .../gdma_main.c:513:9: struct list_head [noderef] __rcu *
> .../gdma_main.c:513:9: struct list_head *
> .../gdma_main.c:513:9: error: incompatible types in comparison expression
> (different address spaces):
> .../gdma_main.c:513:9: struct list_head [noderef] __rcu *
> .../gdma_main.c:513:9: struct list_head *
>
> Perhaps using list_for_each_entry_rcu() is appropriate here.
Thank you, I will fix this.
Long
next prev parent reply other threads:[~2023-11-27 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 3:10 [Patch v1 0/4] longli
2023-11-23 3:10 ` [Patch v1 1/4] RDMA/mana_ib: register RDMA device with GDMA longli
2023-11-23 3:10 ` [Patch v1 2/4] RDMA/mana_ib: create and process EQ events longli
2023-11-26 17:15 ` Simon Horman
2023-11-27 19:00 ` Long Li [this message]
2023-11-23 3:10 ` [Patch v1 3/4] RDMA/mana_ib: create RDMA adapter handle longli
2023-11-23 3:10 ` [Patch v1 4/4] RDMA/mana_ib: query device capabilities longli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB3263ECFFD2850220F3F55E29CEBDA@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).