From: Saurabh Singh Sengar <ssengar@linux.microsoft.com>
To: Aditya Nagesh <adityanagesh@linux.microsoft.com>
Cc: adityanagesh@microsoft.com, kys@microsoft.com,
haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Drivers: hv: Cosmetic changes for hv.c and balloon.c
Date: Thu, 18 Apr 2024 08:06:07 -0700 [thread overview]
Message-ID: <20240418150607.GA27653@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <1712899683-20311-1-git-send-email-adityanagesh@linux.microsoft.com>
On Thu, Apr 11, 2024 at 10:28:03PM -0700, Aditya Nagesh wrote:
> Fix issues reported by checkpatch.pl script in hv.c and
> balloon.c
> - Remove unnecessary parentheses
> - Remove extra newlines
> - Remove extra spaces
> - Add spaces between comparison operators
> - Remove comparison with NULL in if statements
>
> No functional changes intended
>
> Signed-off-by: Aditya Nagesh <adityanagesh@linux.microsoft.com>
> ---
> [V3]
> Fix alignment issues in multiline function parameters.
>
> [V2]
> Change Subject from "Drivers: hv: Fix Issues reported by checkpatch.pl script"
> to "Drivers: hv: Cosmetic changes for hv.c and balloon.c"
>
> drivers/hv/hv.c | 35 +++++++-------
> drivers/hv/hv_balloon.c | 101 +++++++++++++++-------------------------
> 2 files changed, 54 insertions(+), 82 deletions(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index a8ad728354cb..4906611475fb 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -45,7 +45,7 @@ int hv_init(void)
> * This involves a hypercall.
> */
> int hv_post_message(union hv_connection_id connection_id,
> - enum hv_message_type message_type,
> + enum hv_message_type message_type,
This line is fixed now, but now below line is unaligned.
> void *payload, size_t payload_size)
> {
<snip>
>
> if (req->more_pages == 1)
> return;
> @@ -1415,7 +1395,7 @@ static int dm_thread_func(void *dm_dev)
>
> while (!kthread_should_stop()) {
> wait_for_completion_interruptible_timeout(
> - &dm_device.config_event, 1*HZ);
> + &dm_device.config_event, 1 * HZ);
IMO, we can move this to previous line, as now 100 characters are allowed in single line.
Once fixed above,
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
- Saurabh
prev parent reply other threads:[~2024-04-18 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 5:28 [PATCH v3] Drivers: hv: Cosmetic changes for hv.c and balloon.c Aditya Nagesh
2024-04-18 15:06 ` Saurabh Singh Sengar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418150607.GA27653@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=ssengar@linux.microsoft.com \
--cc=adityanagesh@linux.microsoft.com \
--cc=adityanagesh@microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).