From: Saurabh Singh Sengar <ssengar@linux.microsoft.com>
To: Long Li <longli@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Dexuan Cui <decui@microsoft.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [PATCH v2 5/7] tools: hv: Add new fcopy application based on uio driver
Date: Tue, 26 Mar 2024 20:40:37 -0700 [thread overview]
Message-ID: <20240327034037.GA22340@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20240321180705.GA12387@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Thu, Mar 21, 2024 at 11:07:06AM -0700, Saurabh Singh Sengar wrote:
> On Thu, Mar 21, 2024 at 04:42:44PM +0000, Long Li wrote:
> > > Subject: [PATCH v2 5/7] tools: hv: Add new fcopy application based on uio driver
> > >
> > > New fcopy application using uio_hv_generic driver. This application copies file
> > > from Hyper-V host to guest VM.
> > >
> > > A big part of this code is copied from tools/hv/hv_fcopy_daemon.c which this new
> > > application is replacing.
> > >
> > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> > > ---
> > > [V2]
> > > - Improve commit message.
> > > - Change (4 * 4096) to 0x4000 for ring buffer size
> > > - Removed some unnecessary type casting.
> > > - Mentioned in file copy right header that this code is copied.
> > > - Changed the print from "Registration failed" to "Signal to host failed".
> > > - Fixed mask for rx buffer interrupt to 0 before waiting for interrupt.
> > >
> > > tools/hv/Build | 3 +-
> > > tools/hv/Makefile | 10 +-
> > > tools/hv/hv_fcopy_uio_daemon.c | 490
> > > +++++++++++++++++++++++++++++++++
> > > 3 files changed, 497 insertions(+), 6 deletions(-) create mode 100644
> > > tools/hv/hv_fcopy_uio_daemon.c
> > >
> > > diff --git a/tools/hv/Build b/tools/hv/Build index 6cf51fa4b306..7d1f1698069b
> > > 100644
> > > --- a/tools/hv/Build
> > > +++ b/tools/hv/Build
> > > @@ -1,3 +1,4 @@
> > > hv_kvp_daemon-y += hv_kvp_daemon.o
> > > hv_vss_daemon-y += hv_vss_daemon.o
> > > -hv_fcopy_daemon-y += hv_fcopy_daemon.o
> > > +hv_fcopy_uio_daemon-y += hv_fcopy_uio_daemon.o hv_fcopy_uio_daemon-y
> > > +=
> > > +vmbus_bufring.o
> > > diff --git a/tools/hv/Makefile b/tools/hv/Makefile index
> > > fe770e679ae8..944180cf916e 100644
> > > --- a/tools/hv/Makefile
> > > +++ b/tools/hv/Makefile
> >
> > I'm not sure if vmbus_bufring will compile on ARM.
> > If it's not supported, can use some flags in Makefile to not build this.
>
> You are right, this is not supported on ARM64. I can query uname in Makefile
> and compile this only for arch != aarch64.
> I will add this info in commit message as well.
>
> - Saurabh
Greg/Long,
I will be sending the V3 fixing above comment. Hope there are no
further comments.
- Saurabh
next prev parent reply other threads:[~2024-03-27 3:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 10:29 [PATCH v2 0/7] Low speed Hyper-V devices support Saurabh Sengar
2024-03-20 10:29 ` [PATCH v2 1/7] Drivers: hv: vmbus: Add utility function for querying ring size Saurabh Sengar
2024-03-20 10:29 ` [PATCH v2 2/7] uio_hv_generic: Query the ringbuffer size for device Saurabh Sengar
2024-03-20 10:29 ` [PATCH v2 3/7] uio_hv_generic: Enable interrupt for low speed VMBus devices Saurabh Sengar
2024-03-20 10:29 ` [PATCH v2 4/7] tools: hv: Add vmbus_bufring Saurabh Sengar
2024-03-20 10:29 ` [PATCH v2 5/7] tools: hv: Add new fcopy application based on uio driver Saurabh Sengar
2024-03-21 16:42 ` Long Li
2024-03-21 18:07 ` Saurabh Singh Sengar
2024-03-27 3:40 ` Saurabh Singh Sengar [this message]
2024-03-20 10:29 ` [PATCH v2 6/7] Drivers: hv: Remove fcopy driver Saurabh Sengar
2024-03-20 10:29 ` [PATCH v2 7/7] uio_hv_generic: Remove use of PAGE_SIZE Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327034037.GA22340@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=ssengar@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=ssengar@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).