From: Naresh Solanki <naresh.solanki@9elements.com>
To: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
mazziesaccount@gmail.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties
Date: Thu, 7 Mar 2024 15:43:09 +0530 [thread overview]
Message-ID: <CABqG17h5fU4nueaz235XXjJwuPJoLmjo3fs-xZ5mFjtGGYQFkA@mail.gmail.com> (raw)
In-Reply-To: <20240306-decay-overbid-9c8ea43a511f@spud>
Hi,
On Thu, 7 Mar 2024 at 00:08, Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Mar 06, 2024 at 03:20:02PM +0530, Naresh Solanki wrote:
> > Hi Krzysztof,
> >
> >
> > On Wed, 6 Mar 2024 at 12:44, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> > >
> > > On 05/03/2024 22:07, Naresh Solanki wrote:
> > > > Add properties for interrupt & regulator.
> > > > Also update example.
> > >
> > > Nothing improved.
> > Yes, Just aligned the regulator node name in this revision.
> > I missed aligning the commit message.
> >
> > I'll fix in next revision & update commit message as:
> >
> > tda38640 has a single regulator output along with
> > CAT_FAULT# pin to report internal events.
> > Hence add properties for regulator & interrupt.
> >
> > Let me know if any others changes needed.
>
> That should be fine - but your line wrapping is really odd, you can make
> use of 72 characters but you are wrapping at ~50.
Sure. Will push another revision with the changes.
Thanks & Regards,
Naresh
prev parent reply other threads:[~2024-03-07 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 21:07 [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties Naresh Solanki
2024-03-06 7:14 ` Krzysztof Kozlowski
2024-03-06 9:50 ` Naresh Solanki
2024-03-06 18:38 ` Conor Dooley
2024-03-07 10:13 ` Naresh Solanki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABqG17h5fU4nueaz235XXjJwuPJoLmjo3fs-xZ5mFjtGGYQFkA@mail.gmail.com \
--to=naresh.solanki@9elements.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).