From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andy@black.fi.intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: rafael@kernel.org, lenb@kernel.org, jdelvare@suse.com,
robert.moore@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
acpica-devel@lists.linux.dev
Subject: Re: [PATCH v5 2/2] hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell systems
Date: Mon, 25 Mar 2024 07:40:03 -0700 [thread overview]
Message-ID: <4ac8a198-b0c9-418e-bcf8-1ee1a9660dad@roeck-us.net> (raw)
In-Reply-To: <ZgFwLXzNG2aTL_BQ@black.fi.intel.com>
On 3/25/24 05:38, Andy Shevchenko wrote:
> On Wed, Mar 20, 2024 at 04:43:17PM +0800, Kai-Heng Feng wrote:
>> The following error can be observed at boot:
>> [ 3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c5) [IPMI] (20230628/evregion-130)
>> [ 3.717928] ACPI Error: Region IPMI (ID=7) has no handler (20230628/exfldio-261)
>>
>> [ 3.717936] No Local Variables are initialized for Method [_GHL]
>>
>> [ 3.717938] No Arguments are initialized for method [_GHL]
>>
>> [ 3.717940] ACPI Error: Aborting method \_SB.PMI0._GHL due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
>> [ 3.717949] ACPI Error: Aborting method \_SB.PMI0._PMC due to previous error (AE_NOT_EXIST) (20230628/psparse-529)
>> [ 3.717957] ACPI: \_SB_.PMI0: _PMC evaluation failed: AE_NOT_EXIST
>>
>> On Dell systems several methods of acpi_power_meter access variables in
>> IPMI region [0], so wait until IPMI space handler is installed by
>> acpi_ipmi and also wait until SMI is selected to make the space handler
>> fully functional.
>>
>> Since the dependency is inside BIOS's ASL code and it's not
>> discoverable, so use this fixup is a hack to workaround BIOS issue.
>
> ...
>
>> + if (dmi_match(DMI_SYS_VENDOR, "Dell Inc.")) {
>> + ipi_device = acpi_dev_get_first_match_dev("IPI0001", NULL, -1);
>> +
>> + if (ipi_device) {
>> + if (acpi_wait_for_acpi_ipmi())
>> + dev_warn(&device->dev, "Waiting for ACPI IPMI timeout");
>> + acpi_dev_put(ipi_device);
>> + }
>
> Can be written as
>
> if (dmi_match(DMI_SYS_VENDOR, "Dell Inc.")) {
> ipi_device = acpi_dev_get_first_match_dev("IPI0001", NULL, -1);
> if (ipi_device && acpi_wait_for_acpi_ipmi())
> dev_warn(&device->dev, "Waiting for ACPI IPMI timeout");
> acpi_dev_put(ipi_device);
>
>> + }
>
Ah yes, acpi_dev_put() checks if the parameter is NULL. Good point.
I'll make that change, no need to resend.
Thanks,
Guenter
next prev parent reply other threads:[~2024-03-25 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 8:43 [PATCH v5 1/2] ACPI: IPMI: Add helper to wait for when SMI is selected Kai-Heng Feng
2024-03-20 8:43 ` [PATCH v5 2/2] hwmon: (acpi_power_meter) Ensure IPMI space handler is ready on Dell systems Kai-Heng Feng
2024-03-20 18:01 ` Guenter Roeck
2024-03-25 12:38 ` Andy Shevchenko
2024-03-25 14:40 ` Guenter Roeck [this message]
2024-03-20 18:00 ` [PATCH v5 1/2] ACPI: IPMI: Add helper to wait for when SMI is selected Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ac8a198-b0c9-418e-bcf8-1ee1a9660dad@roeck-us.net \
--to=linux@roeck-us.net \
--cc=acpica-devel@lists.linux.dev \
--cc=andy@black.fi.intel.com \
--cc=jdelvare@suse.com \
--cc=kai.heng.feng@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).