From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jean Delvare <jdelvare@suse.com>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
linux-hwmon@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
kernel@pengutronix.de, Billy Tsai <billy_tsai@aspeedtech.com>
Subject: Re: [PATCH] hwmon: (aspeed-g6-pwm-tach) Convert to platform remove callback returning void
Date: Wed, 10 Apr 2024 08:06:11 -0700 [thread overview]
Message-ID: <1bc1f772-1576-4496-af4d-5123869838bf@roeck-us.net> (raw)
In-Reply-To: <20240409085552.19868-2-u.kleine-koenig@pengutronix.de>
On Tue, Apr 09, 2024 at 10:55:53AM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2024-04-10 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 8:55 [PATCH] hwmon: (aspeed-g6-pwm-tach) Convert to platform remove callback returning void Uwe Kleine-König
2024-04-09 11:50 ` Andrew Jeffery
2024-04-10 15:06 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bc1f772-1576-4496-af4d-5123869838bf@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).