From: Andy Lutomirski <luto@amacapital.net>
To: linux-kernel@vger.kernel.org, Kay Sievers <kay@vrfy.org>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
systemd-devel@lists.freedesktop.org,
"Linux Wireless List" <linux-wireless@vger.kernel.org>,
linux-hotplug@vger.kernel.org,
"Intel Linux Wireless" <ilw@linux.intel.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Andy Lutomirski" <luto@amacapital.net>
Subject: [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it
Date: Mon, 05 Aug 2013 16:29:17 +0000 [thread overview]
Message-ID: <325b19bb936d7ebae11edad86aac8f0931e8abd9.1375719828.git.luto@amacapital.net> (raw)
In-Reply-To: <CALCETrXSnFPFVPkXHwz+FFA3=+pmz9V=cMHWwtN+jG1QJALWSQ@mail.gmail.com>
The systemd commit below can delay firmware loading by multiple
minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one
noticed that the systemd-udev change would break new kernels as well
as old kernels.
Since the kernel apparently can't count on reasonable userspace
support, turn this thing off by default.
commit a3bd8447be4ea2ce230eb8ae0e815c04d85fa15a
Author: Tom Gundersen <teg@jklm.no>
Date: Mon Mar 18 15:12:18 2013 +0100
udev: make firmware loading optional and disable by default
Distros that whish to support old kernels should set
--with-firmware-dirs="/usr/lib/firmware/updates:/usr/lib/firmware"
to retain the old behaviour.
---
drivers/base/Kconfig | 15 +++++++++++----
drivers/firmware/Kconfig | 1 -
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 5daa259..de3903e 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -146,13 +146,20 @@ config EXTRA_FIRMWARE_DIR
config FW_LOADER_USER_HELPER
bool "Fallback user-helper invocation for firmware loading"
depends on FW_LOADER
- default y
+ default n
help
This option enables / disables the invocation of user-helper
(e.g. udev) for loading firmware files as a fallback after the
- direct file loading in kernel fails. The user-mode helper is
- no longer required unless you have a special firmware file that
- resides in a non-standard path.
+ direct file loading in kernel fails.
+
+ Since March 2013, a default udev build does not understand
+ firmware loading requests. These udev versions will not
+ even indicate failure; instead they cause long timeouts.
+ This can dramatically slow down the boot process.
+
+ Say Y only if you have special firmware-loading requirements
+ and if you have a non-standard helper that will handle these
+ requests.
config DEBUG_DRIVER
bool "Driver Core verbose debug messages"
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 07478728..9387630 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -64,7 +64,6 @@ config DELL_RBU
tristate "BIOS update support for DELL systems via sysfs"
depends on X86
select FW_LOADER
- select FW_LOADER_USER_HELPER
help
Say m if you want to have the option of updating the BIOS for your
DELL system. Note you need a Dell OpenManage or Dell Update package (DUP)
--
1.8.3.1
next prev parent reply other threads:[~2013-08-05 16:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 16:04 Slow firmware timeouts again (Re: [3.11 regression?] iwlwifi firmware takes two minutes to load) Andy Lutomirski
2013-08-02 16:21 ` Johannes Berg
2013-08-02 16:24 ` Andy Lutomirski
2013-08-02 16:28 ` Zbigniew Jędrzejewski-Szmek
2013-08-05 11:18 ` [systemd-devel] Slow firmware timeouts again (Re: [3.11 regression?] iwlwifi firmware takes two Kay Sievers
2013-08-05 16:09 ` Andy Lutomirski
2013-08-05 16:29 ` Andy Lutomirski [this message]
2013-08-06 8:20 ` [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it Maarten Lankhorst
2013-08-06 9:11 ` [systemd-devel] " Tom Gundersen
2013-08-06 9:17 ` Tom Gundersen
2013-08-06 16:08 ` Andy Lutomirski
2013-08-06 16:31 ` Bryan Kadzban
[not found] ` <CAG-2HqU=yyxomNTg9-2+bxMKP=e5_pdVT7bhB_CHhFzB-ac_mQ@mail.gmail.com>
2013-08-07 0:26 ` Andy Lutomirski
2013-08-07 7:52 ` [PATCH] udev: fail firmware loading immediately if no search path is defined Maarten Lankhorst
2013-08-07 21:24 ` Andy Lutomirski
[not found] ` <CAG-2HqUT3hbFPSEqYnJvBOgS6p4dKf=nhqZtzqS-on8FFe9ipA@mail.gmail.com>
2013-08-10 21:28 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325b19bb936d7ebae11edad86aac8f0931e8abd9.1375719828.git.luto@amacapital.net \
--to=luto@amacapital.net \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=kay@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=systemd-devel@lists.freedesktop.org \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).