From: Greg KH <greg@kroah.com>
To: Rusty Russell <rusty@rustcorp.com.au>, Kay Sievers <kay@vrfy.org>
Cc: Milos Vyletel <milos.vyletel@sde.cz>,
linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org,
virtualization@lists.linux-foundation.org, mst@redhat.com
Subject: Re: [PATCH] virtio-blk: emit udev event when device is resized
Date: Mon, 25 Feb 2013 22:12:38 +0000 [thread overview]
Message-ID: <20130225221238.GA10575@kroah.com> (raw)
In-Reply-To: <87y5ehfczy.fsf@rustcorp.com.au>
On Fri, Feb 22, 2013 at 10:14:49AM +1030, Rusty Russell wrote:
> Milos Vyletel <milos.vyletel@sde.cz> writes:
>
> > When virtio-blk device is resized from host (using block_resize from QEMU) emit
> > KOBJ_CHANGE uevent to notify guest about such change. This allows user to have
> > custom udev rules which would take whatever action if such event occurs. As a
> > proof of concept I've created simple udev rule that automatically resize
> > filesystem on virtio-blk device.
> >
> > ACTION="change", KERNEL="vd*", \
> > ENV{RESIZE}="1", \
> > ENV{ID_FS_TYPE}="ext[3-4]", \
> > RUN+="/sbin/resize2fs /dev/%k"
> > ACTION="change", KERNEL="vd*", \
> > ENV{RESIZE}="1", \
> > ENV{ID_FS_TYPE}="LVM2_member", \
> > RUN+="/sbin/pvresize /dev/%k"
>
> This looks fine to me, but I like to check with Greg before adding udev
> callouts.... Greg?
Hm, I thought we were frowning apon running binaries from udev rules
these days, especially ones that might have big consequences (like
resizing a disk image) like this.
Kay, am I right?
We already emit KOBJECT_CHANGE events when block devices change, from
within the block core code. Why is the patch below needed instead of
using these events that are already generated? How are virtio block
devices special?
> BTW, if this is good, it's good for stable IMHO.
What bug does it fix?
thanks,
greg k-h
> Cheers,
> Rusty.
>
> > Signed-off-by: Milos Vyletel <milos.vyletel@sde.cz>
> > ---
> > drivers/block/virtio_blk.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> > index 8ad21a2..5990382 100644
> > --- a/drivers/block/virtio_blk.c
> > +++ b/drivers/block/virtio_blk.c
> > @@ -539,6 +539,8 @@ static void virtblk_config_changed_work(struct work_struct *work)
> > struct virtio_device *vdev = vblk->vdev;
> > struct request_queue *q = vblk->disk->queue;
> > char cap_str_2[10], cap_str_10[10];
> > + char event[] = "RESIZE=1";
> > + char *envp[] = { event, NULL };
> > u64 capacity, size;
> >
> > mutex_lock(&vblk->config_lock);
> > @@ -568,6 +570,7 @@ static void virtblk_config_changed_work(struct work_struct *work)
> >
> > set_capacity(vblk->disk, capacity);
> > revalidate_disk(vblk->disk);
> > + kobject_uevent_env(&disk_to_dev(vblk->disk)->kobj, KOBJ_CHANGE, envp);
> > done:
> > mutex_unlock(&vblk->config_lock);
> > }
> > --
> > 1.7.1
next parent reply other threads:[~2013-02-25 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361473348-7660-1-git-send-email-milos.vyletel@sde.cz>
[not found] ` <87y5ehfczy.fsf@rustcorp.com.au>
2013-02-25 22:12 ` Greg KH [this message]
2013-02-25 22:39 ` [PATCH] virtio-blk: emit udev event when device is resized Kay Sievers
2013-02-25 22:43 ` Greg KH
2013-02-25 23:04 ` Kay Sievers
2013-02-25 23:38 ` Milos Vyletel
2013-02-25 23:41 ` Milos Vyletel
2013-02-27 0:46 ` Rusty Russell
2013-02-27 13:09 ` Milos Vyletel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225221238.GA10575@kroah.com \
--to=greg@kroah.com \
--cc=kay@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milos.vyletel@sde.cz \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).