From: Stafford Horne <shorne@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Brian Cain <bcain@codeaurora.org>, Nick Hu <nickhu@andestech.com>,
Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Russell King <rmk+kernel@armlinux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
linux-hexagon@vger.kernel.org, openrisc@lists.librecores.org
Subject: Re: [PATCH] mm: Remove mmu_gathers storage from remaining architectures
Date: Sun, 6 Feb 2022 12:19:43 +0900 [thread overview]
Message-ID: <Yf8+T8Ow7n+38w2H@antec> (raw)
In-Reply-To: <Yf6UthQtASGNgW8Q@kernel.org>
On Sat, Feb 05, 2022 at 05:16:06PM +0200, Mike Rapoport wrote:
> On Sat, Feb 05, 2022 at 11:19:53PM +0900, Stafford Horne wrote:
> > Originally the mmu_gathers were removed in commit 1c3951769621 ("mm: now
> > that all old mmu_gather code is gone, remove the storage"). However,
> > the openrisc and hexagon architecture were merged around the same time
> > and mmu_gathers was not removed.
> >
> > This patch removes them from openrisc, hexagon and nds32:
> >
> > Noticed while cleaning this warning:
> >
> > arch/openrisc/mm/init.c:41:1: warning: symbol 'mmu_gathers' was not declared. Should it be static?
> >
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
>
> Acked-by: Mike Rapoport <rppt@linux.ibm.com>
Thank you,
BTW For now my plan is to queue this on my openrisc branch unless someone else
wants to pick this up.
-Stafford
> > ---
> > arch/hexagon/mm/init.c | 2 --
> > arch/nds32/mm/init.c | 1 -
> > arch/openrisc/mm/init.c | 2 --
> > 3 files changed, 5 deletions(-)
> >
> > diff --git a/arch/hexagon/mm/init.c b/arch/hexagon/mm/init.c
> > index f01e91e10d95..3167a3b5c97b 100644
> > --- a/arch/hexagon/mm/init.c
> > +++ b/arch/hexagon/mm/init.c
> > @@ -29,8 +29,6 @@ int max_kernel_seg = 0x303;
> > /* indicate pfn's of high memory */
> > unsigned long highstart_pfn, highend_pfn;
> >
> > -DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
> > -
> > /* Default cache attribute for newly created page tables */
> > unsigned long _dflt_cache_att = CACHEDEF;
> >
> > diff --git a/arch/nds32/mm/init.c b/arch/nds32/mm/init.c
> > index f63f839738c4..825c85cab1a1 100644
> > --- a/arch/nds32/mm/init.c
> > +++ b/arch/nds32/mm/init.c
> > @@ -18,7 +18,6 @@
> > #include <asm/tlb.h>
> > #include <asm/page.h>
> >
> > -DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
> > DEFINE_SPINLOCK(anon_alias_lock);
> > extern pgd_t swapper_pg_dir[PTRS_PER_PGD];
> >
> > diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> > index 97305bde1b16..3a021ab6f1ae 100644
> > --- a/arch/openrisc/mm/init.c
> > +++ b/arch/openrisc/mm/init.c
> > @@ -38,8 +38,6 @@
> >
> > int mem_init_done;
> >
> > -DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
> > -
> > static void __init zone_sizes_init(void)
> > {
> > unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
> > --
> > 2.31.1
> >
>
> --
> Sincerely yours,
> Mike.
prev parent reply other threads:[~2022-02-06 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 14:19 [PATCH] mm: Remove mmu_gathers storage from remaining architectures Stafford Horne
2022-02-05 15:16 ` Mike Rapoport
2022-02-06 3:19 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf8+T8Ow7n+38w2H@antec \
--to=shorne@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bcain@codeaurora.org \
--cc=christophe.leroy@c-s.fr \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickhu@andestech.com \
--cc=openrisc@lists.librecores.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).