From: Stafford Horne <shorne@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@kernel.org>, Guo Ren <guoren@kernel.org>,
Brian Cain <bcain@codeaurora.org>,
Michal Simek <monstr@monstr.eu>, Nick Hu <nickhu@andestech.com>,
Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-csky@vger.kernel.org
Subject: Re: architectures that still need to remove set_fs()
Date: Tue, 18 Jan 2022 20:48:17 +0900 [thread overview]
Message-ID: <YeapAai1NIuy0zV4@antec> (raw)
In-Reply-To: <20220118074836.GA20994@lst.de>
Hi,
On Tue, Jan 18, 2022 at 08:48:36AM +0100, Christoph Hellwig wrote:
> Hi all,
>
> you are in this list because your architecture still implements and
> uses address space overrides using set_fs(), which are deprecated and
> have been removed from all mainstream architecture ports. To help
> cleanup the core kernel it would be great to make progress on removing
> set_fs entirely.
>
> The following steps are required:
>
> (1) implement the __get_kernel_nofault and __put_kernel_nofault
> helper to access kernel memory without page faults, replacing
> the get/put_user under set_fs(KERNEL_DS) abuse. Mips has a good
> example for a trivial implementation for architectures that use
> a common address space in commit 04324f44cb69
Also see commit 08ee3a009f49a which is preparation for removing set_fs/get_fs
this commit implements __get_kernel_nofault/__put_kernel_nofault for mips.
> (2) remove any architecture specific use of such constructs. This
> only affects ia64 and sh.
> (3) stop selecting the SET_FS and remove all the set_fs-related
> infrastructure. The above mips commit is a good guide once again.
>
> Thanks!
I will look into this for OpenRISC.
-Stafford
prev parent reply other threads:[~2022-01-18 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 7:48 architectures that still need to remove set_fs() Christoph Hellwig
2022-01-18 11:48 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeapAai1NIuy0zV4@antec \
--to=shorne@gmail.com \
--cc=bcain@codeaurora.org \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=dinguyen@kernel.org \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=hch@lst.de \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mattst88@gmail.com \
--cc=monstr@monstr.eu \
--cc=nickhu@andestech.com \
--cc=rth@twiddle.net \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=vgupta@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).