From: Brian Cain <bcain@quicinc.com>
To: Atul Raut <rauji.raut@gmail.com>
Cc: "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
"linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: RE: hexagon: fix warning comparing pointer to 0
Date: Wed, 9 Aug 2023 19:04:33 +0000 [thread overview]
Message-ID: <SN6PR02MB420564C1F86A0BB6E76E24DEB812A@SN6PR02MB4205.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20230809185147.98262-1-rauji.raut@gmail.com>
> -----Original Message-----
> From: Atul Raut <rauji.raut@gmail.com>
> Sent: Wednesday, August 9, 2023 1:52 PM
> To: Brian Cain <bcain@quicinc.com>
> Cc: linux-hexagon@vger.kernel.org; linux-kernel-
> mentees@lists.linuxfoundation.org
> Subject: hexagon: fix warning comparing pointer to 0
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> Fix the following coccicheck warning:
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>
> ---
> arch/hexagon/kernel/traps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index 6447763ce5a9..78486eea77d7 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -80,7 +80,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
> int kstack_depth_to_print = 24;
> unsigned long offset, size;
> const char *name = NULL;
> - unsigned long *newfp;
> + unsigned long *newfp = NULL;
> unsigned long low, high;
> char tmpstr[128];
> char *modname;
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
> }
>
> /* Attempt to continue past exception. */
> - if (0 == newfp) {
> + if (!newfp) {
> struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
> + 8);
>
> --
> 2.34.1
Acked-by: Brian Cain <bcain@quicinc.com>
prev parent reply other threads:[~2023-08-09 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 18:51 hexagon: fix warning comparing pointer to 0 Atul Raut
2023-08-09 19:04 ` Brian Cain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR02MB420564C1F86A0BB6E76E24DEB812A@SN6PR02MB4205.namprd02.prod.outlook.com \
--to=bcain@quicinc.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=rauji.raut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).