From: Brian Cain <bcain@quicinc.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>
Cc: "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
Date: Thu, 15 Feb 2024 19:12:38 +0000 [thread overview]
Message-ID: <CH3PR02MB102474087819FEC83FA6C08AEB84D2@CH3PR02MB10247.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20240215140702.1910276-1-masahiroy@kernel.org>
> -----Original Message-----
> From: Masahiro Yamada <masahiroy@kernel.org>
> Sent: Thursday, February 15, 2024 8:07 AM
> To: linux-kbuild@vger.kernel.org
> Cc: Masahiro Yamada <masahiroy@kernel.org>; Brian Cain
> <bcain@quicinc.com>; linux-hexagon@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>
> Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS
> must
> also be selected to avoid the unmet dependency warning.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/hexagon/Kconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index a880ee067d2e..e922026fef09 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -7,7 +7,9 @@ config HEXAGON
> select ARCH_32BIT_OFF_T
> select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_NO_PREEMPT
> + select ARCH_WANT_FRAME_POINTERS
> select DMA_GLOBAL_POOL
> + select FRAME_POINTER
> # Other pending projects/to-do items.
> # select HAVE_REGS_AND_STACK_ACCESS_API
> # select HAVE_HW_BREAKPOINT if PERF_EVENTS
> @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET
> help
> Platforms that don't load the kernel at zero set this.
>
> -config FRAME_POINTER
> - def_bool y
> -
> config LOCKDEP_SUPPORT
> def_bool y
>
> --
> 2.40.1
Acked-by: Brian Cain <bcain@quicinc.com>
prev parent reply other threads:[~2024-02-15 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 14:07 [PATCH] hexagon: select FRAME_POINTER instead of redefining it Masahiro Yamada
2024-02-15 17:03 ` Randy Dunlap
2024-02-15 19:12 ` Brian Cain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR02MB102474087819FEC83FA6C08AEB84D2@CH3PR02MB10247.namprd02.prod.outlook.com \
--to=bcain@quicinc.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).