From: Vishal Moola <vishal.moola@gmail.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org, Hugh Dickins <hughd@google.com>,
David Hildenbrand <david@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH mm-unstable v9 14/31] s390: Convert various pgalloc functions to use ptdescs
Date: Fri, 13 Oct 2023 14:03:08 -0700 [thread overview]
Message-ID: <CAOzc2px-SFSnmjcPriiB3cm1fNj3+YC8S0VSp4t1QvDR0f4E2A@mail.gmail.com> (raw)
In-Reply-To: <20231012072505.6160-A-hca@linux.ibm.com>
On Thu, Oct 12, 2023 at 12:25 AM Heiko Carstens <hca@linux.ibm.com> wrote:
>
> On Mon, Aug 07, 2023 at 04:04:56PM -0700, Vishal Moola (Oracle) wrote:
> > As part of the conversions to replace pgtable constructor/destructors with
> > ptdesc equivalents, convert various page table functions to use ptdescs.
> >
> > Some of the functions use the *get*page*() helper functions. Convert
> > these to use pagetable_alloc() and ptdesc_address() instead to help
> > standardize page tables further.
> >
> > Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> > arch/s390/include/asm/pgalloc.h | 4 +-
> > arch/s390/include/asm/tlb.h | 4 +-
> > arch/s390/mm/pgalloc.c | 128 ++++++++++++++++----------------
> > 3 files changed, 69 insertions(+), 67 deletions(-)
> ...
> > diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c
> > index d7374add7820..07fc660a24aa 100644
> > --- a/arch/s390/mm/pgalloc.c
> > +++ b/arch/s390/mm/pgalloc.c
> ...
> > @@ -488,16 +486,20 @@ static void base_pgt_free(unsigned long *table)
> > static unsigned long *base_crst_alloc(unsigned long val)
> > {
> > unsigned long *table;
> > + struct ptdesc *ptdesc;
> >
> > - table = (unsigned long *)__get_free_pages(GFP_KERNEL, CRST_ALLOC_ORDER);
> > - if (table)
> > - crst_table_init(table, val);
> > + ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, CRST_ALLOC_ORDER);
>
> I guess I must miss something, but what is the reason to mask out
> __GFP_HIGHMEM here? It is not part of GFP_KERNEL, nor does s390 support
> HIGHMEM.
You're not missing anything.
This was replacing __get_free_pages() which also doesn't support HIGHMEM,
so I had that in to ensure a non-HIGHMEM allocation in case a
passed-in gfp_flags
had it set. In hindsight since we're just passing in the GFP flags
directly here, we don't
actually need to mask out GFP_HIGHMEM.
next prev parent reply other threads:[~2023-10-13 21:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 23:04 [PATCH mm-unstable v9 00/31] Split ptdesc from struct page Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 01/31] mm: Add PAGE_TYPE_OP folio functions Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 02/31] pgtable: create struct ptdesc Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 03/31] mm: add utility functions for ptdesc Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 04/31] mm: Convert pmd_pgtable_page() callers to use pmd_ptdesc() Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 05/31] mm: Convert ptlock_alloc() to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 06/31] mm: Convert ptlock_ptr() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 07/31] mm: Convert pmd_ptlock_init() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 08/31] mm: Convert ptlock_init() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 09/31] mm: Convert pmd_ptlock_free() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 10/31] mm: Convert ptlock_free() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 11/31] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 12/31] powerpc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 13/31] x86: " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 14/31] s390: Convert various pgalloc " Vishal Moola (Oracle)
2023-10-12 7:25 ` Heiko Carstens
2023-10-13 21:03 ` Vishal Moola [this message]
2023-08-07 23:04 ` [PATCH mm-unstable v9 15/31] mm: remove page table members from struct page Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 16/31] pgalloc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 17/31] arm: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 18/31] arm64: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 19/31] csky: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 20/31] hexagon: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 21/31] loongarch: Convert various functions " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 22/31] m68k: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 23/31] mips: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 24/31] nios2: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 25/31] openrisc: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 26/31] riscv: Convert alloc_{pmd, pte}_late() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 27/31] sh: Convert pte_free_tlb() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 28/31] sparc64: Convert various functions " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 29/31] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 30/31] um: Convert {pmd, pte}_free_tlb() to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 31/31] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOzc2px-SFSnmjcPriiB3cm1fNj3+YC8S0VSp4t1QvDR0f4E2A@mail.gmail.com \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hca@linux.ibm.com \
--cc=hughd@google.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).