From: Thomas Huth <thuth@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Oleg Nesterov <oleg@redhat.com>,
linux-hexagon@vger.kernel.org, Brian Cain <bcain@quicinc.com>
Cc: linux-kernel@vger.kernel.org, Richard Kuo <rkuo@codeaurora.org>
Subject: Re: [PATCH] hexagon: Remove unusable symbols from the ptrace.h uapi
Date: Wed, 25 Oct 2023 16:15:31 +0200 [thread overview]
Message-ID: <8af7e036-1be2-4bb3-9ae8-3ee4aa49b00a@redhat.com> (raw)
In-Reply-To: <5e5e3e9b-dc16-428c-bd7f-d723960beb3c@app.fastmail.com>
On 25/10/2023 15.59, Arnd Bergmann wrote:
> On Wed, Oct 25, 2023, at 09:38, Thomas Huth wrote:
>> Kernel-internal prototypes, references to current_thread_info()
>> and code hidden behind a CONFIG_HEXAGON_ARCH_VERSION switch are
>> certainly not usable in userspace, so this should not reside
>> in a uapi header. Move the code into an internal version of
>> ptrace.h instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> I've compile tested it now with a hexagon cross-compiler and the kernel
>> compiles fine with this change, so I think this should be good to go.
>
> I've applied this to the asm-generic tree, thanks for the
> patch.
Thanks!
>> +++ b/scripts/headers_install.sh
>> @@ -74,7 +74,6 @@ arch/arc/include/uapi/asm/page.h:CONFIG_ARC_PAGE_SIZE_16K
>> arch/arc/include/uapi/asm/page.h:CONFIG_ARC_PAGE_SIZE_4K
>> arch/arc/include/uapi/asm/swab.h:CONFIG_ARC_HAS_SWAPE
>> arch/arm/include/uapi/asm/ptrace.h:CONFIG_CPU_ENDIAN_BE8
>> -arch/hexagon/include/uapi/asm/ptrace.h:CONFIG_HEXAGON_ARCH_VERSION
>> arch/hexagon/include/uapi/asm/user.h:CONFIG_HEXAGON_ARCH_VERSION
>> arch/m68k/include/uapi/asm/ptrace.h:CONFIG_COLDFIRE
>> arch/nios2/include/uapi/asm/swab.h:CONFIG_NIOS2_CI_SWAB_NO
>
> Would you like to send another patch for the other hexagon
> file? It looks trivial enough as we can just drop the #if
> portion there and keep the #else side.
Looks like we have at least to look carefully at
arch/hexagon/kernel/ptrace.c first ... pad1 is still used there and the of
offsetof(struct user_regs_struct, pad1) results in different values
depending on the CONFIG switch ... but sure, I can have a try to come up
with a patch.
Thomas
prev parent reply other threads:[~2023-10-25 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 7:38 [PATCH] hexagon: Remove unusable symbols from the ptrace.h uapi Thomas Huth
2023-10-25 13:59 ` Arnd Bergmann
2023-10-25 14:15 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8af7e036-1be2-4bb3-9ae8-3ee4aa49b00a@redhat.com \
--to=thuth@redhat.com \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).