From: Michael Ellerman <mpe@ellerman.id.au>
To: Arnd Bergmann <arnd@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Kees Cook <keescook@chromium.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Guo Ren <guoren@kernel.org>, Brian Cain <bcain@quicinc.com>,
Huacai Chen <chenhuacai@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Helge Deller <deller@gmx.de>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Palmer Dabbelt <palmer@dabbelt.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Andreas Larsson <andreas@gaisler.com>,
Richard Weinberger <richard@nod.at>,
x86@kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kbingham@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [PATCH v2 1/3] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions
Date: Thu, 07 Mar 2024 10:41:02 +1100 [thread overview]
Message-ID: <87sf13nd2p.fsf@mail.lhotse> (raw)
In-Reply-To: <20240306141453.3900574-2-arnd@kernel.org>
Hi Arnd,
Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de>
>
> These four architectures define the same Kconfig symbols for configuring
> the page size. Move the logic into a common place where it can be shared
> with all other architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Changes from v1:
> - improve Kconfig help texts
> - fix Hexagon Kconfig
>
> arch/Kconfig | 92 ++++++++++++++++++++++++++++++-
> arch/hexagon/Kconfig | 24 ++------
> arch/hexagon/include/asm/page.h | 6 +-
> arch/loongarch/Kconfig | 21 ++-----
> arch/loongarch/include/asm/page.h | 10 +---
> arch/mips/Kconfig | 58 ++-----------------
> arch/mips/include/asm/page.h | 16 +-----
> arch/sh/include/asm/page.h | 13 +----
> arch/sh/mm/Kconfig | 42 ++++----------
> 9 files changed, 121 insertions(+), 161 deletions(-)
There's a few "help" lines missing, which breaks the build:
arch/Kconfig:1134: syntax error
arch/Kconfig:1133: invalid statement
arch/Kconfig:1134: invalid statement
arch/Kconfig:1135:warning: ignoring unsupported character '.'
arch/Kconfig:1135:warning: ignoring unsupported character '.'
arch/Kconfig:1135: invalid statement
arch/Kconfig:1136: invalid statement
arch/Kconfig:1137:warning: ignoring unsupported character '.'
arch/Kconfig:1137: invalid statement
arch/Kconfig:1143: syntax error
arch/Kconfig:1142: invalid statement
arch/Kconfig:1143: invalid statement
arch/Kconfig:1144:warning: ignoring unsupported character '.'
arch/Kconfig:1144: invalid statement
arch/Kconfig:1145: invalid statement
arch/Kconfig:1146: invalid statement
arch/Kconfig:1147: invalid statement
arch/Kconfig:1148:warning: ignoring unsupported character '.'
arch/Kconfig:1148: invalid statement
make[4]: *** [../scripts/kconfig/Makefile:85: syncconfig] Error 1
Fixup diff is:
diff --git a/arch/Kconfig b/arch/Kconfig
index 56d45a75f625..f2295fa3b48c 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -1130,6 +1130,7 @@ config PAGE_SIZE_16KB
config PAGE_SIZE_32KB
bool "32KiB pages"
depends on HAVE_PAGE_SIZE_32KB
+ help
Using 32KiB page size will result in slightly higher performance
kernel at the price of higher memory consumption compared to
16KiB pages. This option is available only on cnMIPS cores.
@@ -1139,6 +1140,7 @@ config PAGE_SIZE_32KB
config PAGE_SIZE_64KB
bool "64KiB pages"
depends on HAVE_PAGE_SIZE_64KB
+ help
Using 64KiB page size will result in slightly higher performance
kernel at the price of much higher memory consumption compared to
4KiB or 16KiB pages.
cheers
next prev parent reply other threads:[~2024-03-06 23:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:14 [v2 PATCH 0/3] arch: mm, vdso: consolidate PAGE_SIZE definition Arnd Bergmann
2024-03-06 14:14 ` [PATCH v2 1/3] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions Arnd Bergmann
2024-03-06 17:14 ` Thomas Gleixner
2024-03-06 23:41 ` Michael Ellerman [this message]
2024-03-06 14:14 ` [PATCH v2 2/3] arch: simplify architecture specific page size configuration Arnd Bergmann
2024-03-06 17:16 ` Thomas Gleixner
2024-03-07 12:34 ` Michael Ellerman
2024-03-06 14:14 ` [PATCH v2 3/3] arch: define CONFIG_PAGE_SIZE_*KB on all architectures Arnd Bergmann
2024-03-06 16:23 ` Geert Uytterhoeven
2024-03-06 17:17 ` Thomas Gleixner
2024-03-07 14:42 ` Andreas Larsson
2024-03-06 17:17 ` [v2 PATCH 0/3] arch: mm, vdso: consolidate PAGE_SIZE definition Thomas Gleixner
2024-03-08 16:28 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf13nd2p.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bcain@quicinc.com \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=guoren@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=jcmvbkbc@gmail.com \
--cc=kbingham@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=luto@kernel.org \
--cc=mattst88@gmail.com \
--cc=monstr@monstr.eu \
--cc=palmer@dabbelt.com \
--cc=richard@nod.at \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).