From: "Brian Cain" <bcain@codeaurora.org>
To: 'Peter Xu' <peterx@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
'John Hubbard' <jhubbard@nvidia.com>,
'Michael Ellerman' <mpe@ellerman.id.au>,
'Gerald Schaefer' <gerald.schaefer@de.ibm.com>,
'Andrea Arcangeli' <aarcange@redhat.com>,
'Linus Torvalds' <torvalds@linux-foundation.org>,
'Will Deacon' <will@kernel.org>,
linux-hexagon@vger.kernel.org
Subject: RE: [PATCH v4 07/26] mm/hexagon: Use general page fault accounting
Date: Tue, 30 Jun 2020 17:57:29 -0500 [thread overview]
Message-ID: <283701d64f31$d63a11d0$82ae3570$@codeaurora.org> (raw)
In-Reply-To: <20200630204519.38809-1-peterx@redhat.com>
> -----Original Message-----
> From: linux-hexagon-owner@vger.kernel.org <linux-hexagon-
...
Acked-by: Brian Cain <bcain@codeaurora.org>
> CC: Brian Cain <bcain@codeaurora.org>
> CC: linux-hexagon@vger.kernel.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> arch/hexagon/mm/vm_fault.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/arch/hexagon/mm/vm_fault.c b/arch/hexagon/mm/vm_fault.c
> index f12f330e7946..ef32c5a84ff3 100644
> --- a/arch/hexagon/mm/vm_fault.c
> +++ b/arch/hexagon/mm/vm_fault.c
> @@ -18,6 +18,7 @@
> #include <linux/signal.h>
> #include <linux/extable.h>
> #include <linux/hardirq.h>
> +#include <linux/perf_event.h>
>
> /*
> * Decode of hardware exception sends us to one of several @@ -53,6 +54,8
> @@ void do_page_fault(unsigned long address, long cause, struct pt_regs
> *regs)
>
> if (user_mode(regs))
> flags |= FAULT_FLAG_USER;
> +
> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, address);
> retry:
> mmap_read_lock(mm);
> vma = find_vma(mm, address);
> @@ -88,7 +91,7 @@ void do_page_fault(unsigned long address, long cause,
> struct pt_regs *regs)
> break;
> }
>
> - fault = handle_mm_fault(vma, address, flags, NULL);
> + fault = handle_mm_fault(vma, address, flags, regs);
>
> if (fault_signal_pending(fault, regs))
> return;
> @@ -96,10 +99,6 @@ void do_page_fault(unsigned long address, long cause,
> struct pt_regs *regs)
> /* The most common case -- we are done. */
> if (likely(!(fault & VM_FAULT_ERROR))) {
> if (flags & FAULT_FLAG_ALLOW_RETRY) {
> - if (fault & VM_FAULT_MAJOR)
> - current->maj_flt++;
> - else
> - current->min_flt++;
> if (fault & VM_FAULT_RETRY) {
> flags |= FAULT_FLAG_TRIED;
> goto retry;
> --
> 2.26.2
prev parent reply other threads:[~2020-06-30 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 20:45 [PATCH v4 07/26] mm/hexagon: Use general page fault accounting Peter Xu
2020-06-30 22:57 ` Brian Cain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='283701d64f31$d63a11d0$82ae3570$@codeaurora.org' \
--to=bcain@codeaurora.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=jhubbard@nvidia.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpe@ellerman.id.au \
--cc=peterx@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).