From: "Arnd Bergmann" <arnd@arndb.de>
To: "Nathan Chancellor" <nathan@kernel.org>,
"Brian Cain" <bcain@quicinc.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-hexagon@vger.kernel.org, llvm@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH 00/19] hexagon: Fix up instances of -Wmissing-prototypes
Date: Fri, 01 Dec 2023 08:12:42 +0100 [thread overview]
Message-ID: <170c8da3-068e-43ff-9c0a-6e21555dfab7@app.fastmail.com> (raw)
In-Reply-To: <20231130-hexagon-missing-prototypes-v1-0-5c34714afe9e@kernel.org>
On Thu, Nov 30, 2023, at 23:58, Nathan Chancellor wrote:
> Hi all,
>
> This series fixes all the instances of -Wmissing-prototypes in
> arch/hexagon, now that it is enabled globally in a default build. I hope
> most of the patches will be uncontroversial but please let me know
> otherwise. This survives ARCH=hexagon defconfig and allmodconfig with
> LLVM 17.0.6.
>
> This is based on Arnd's asm-generic-prototypes branch but it applies
> cleanly to 6.7-rc3 as well, in case Andrew wants to take it (as far as
> I remember, he has handled Hexagon patches for me in the past).
The patches all look fine to me. I usually prefer to put prototypes
in a header even if the only caller is in a .S file rather than
adding them in front of the definition, but your version does
the job.
Arnd
prev parent reply other threads:[~2023-12-01 7:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 22:58 [PATCH 00/19] hexagon: Fix up instances of -Wmissing-prototypes Nathan Chancellor
2023-11-30 22:58 ` [PATCH 01/19] hexagon: uaccess: Remove clear_user_hexagon() Nathan Chancellor
2023-11-30 22:58 ` [PATCH 02/19] hexagon: mm: Mark paging_init() as static Nathan Chancellor
2023-11-30 22:58 ` [PATCH 03/19] hexagon: mm: Include asm/setup.h for setup_arch_memory()'s prototype Nathan Chancellor
2023-11-30 22:58 ` [PATCH 04/19] hexagon: smp: Mark handle_ipi() and start_secondary() as static Nathan Chancellor
2023-11-30 22:58 ` [PATCH 05/19] hexagon: vm_fault: Mark do_page_fault() " Nathan Chancellor
2023-11-30 22:58 ` [PATCH 06/19] hexagon: vm_fault: Include asm/vm_fault.h for prototypes Nathan Chancellor
2023-11-30 22:58 ` [PATCH 07/19] hexagon: vm_tlb: Include asm/tlbflush.h " Nathan Chancellor
2023-11-30 22:58 ` [PATCH 08/19] hexagon: time: Include asm/time.h " Nathan Chancellor
2023-11-30 22:58 ` [PATCH 09/19] hexagon: time: Mark time_init_deferred() as static Nathan Chancellor
2023-11-30 22:58 ` [PATCH 10/19] hexagon: time: Include asm/delay.h for prototypes Nathan Chancellor
2023-11-30 22:58 ` [PATCH 11/19] hexagon: signal: Switch to SYSCALL_DEFINE0 for sys_rt_sigreturn() Nathan Chancellor
2023-11-30 22:58 ` [PATCH 12/19] hexagon: reset: Include linux/reboot.h for prototypes Nathan Chancellor
2023-11-30 22:58 ` [PATCH 13/19] hexagon: process: Include linux/cpu.h for arch_cpu_idle() prototype Nathan Chancellor
2023-11-30 22:58 ` [PATCH 14/19] hexagon: process: Add internal prototype for do_work_pending() Nathan Chancellor
2023-11-30 22:58 ` [PATCH 15/19] hexagon: vdso: Include asm/elf.h for arch_setup_additional_pages() prototype Nathan Chancellor
2023-11-30 22:58 ` [PATCH 16/19] hexagon: vm_events: Remove unused dummy_handler() Nathan Chancellor
2023-11-30 22:58 ` [PATCH 17/19] hexagon: irq: Add prototype for arch_do_IRQ() Nathan Chancellor
2023-11-30 22:58 ` [PATCH 18/19] hexagon: traps: Remove sys_syscall() Nathan Chancellor
2023-11-30 22:58 ` [PATCH 19/19] hexagon: traps: Add internal prototypes for functions only called from asm Nathan Chancellor
2023-11-30 23:38 ` [PATCH 00/19] hexagon: Fix up instances of -Wmissing-prototypes Andrew Morton
2023-12-01 7:12 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170c8da3-068e-43ff-9c0a-6e21555dfab7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=bcain@quicinc.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).