From: Kees Cook <keescook@chromium.org>
To: azeemshaikh38@gmail.com, bcain@quicinc.com
Cc: Kees Cook <keescook@chromium.org>,
linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] Hexagon: Replace all non-returning strlcpy with strscpy
Date: Wed, 14 Jun 2023 11:18:31 -0700 [thread overview]
Message-ID: <168676670780.1815023.2376604888079665488.b4-ty@chromium.org> (raw)
In-Reply-To: <20230530162608.984333-1-azeemshaikh38@gmail.com>
On Tue, 30 May 2023 16:26:08 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]
Successfully build tested with Clang 17.
Applied to for-next/hardening, thanks!
[1/1] Hexagon: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/f0e212de87a1
--
Kees Cook
prev parent reply other threads:[~2023-06-14 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 16:26 [PATCH] Hexagon: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-30 23:20 ` Kees Cook
2023-06-14 18:18 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168676670780.1815023.2376604888079665488.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=azeemshaikh38@gmail.com \
--cc=bcain@quicinc.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).