From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Andy Shevchenko <andy@kernel.org>
Cc: keescook@chromium.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH] string: Implement KUnit test for str*cmp functions
Date: Wed, 17 Apr 2024 16:12:45 +0100 [thread overview]
Message-ID: <9f6d22cb-2170-4b80-912a-cfee18381b43@gmail.com> (raw)
In-Reply-To: <Zh_ibi_Y6xogktg-@smile.fi.intel.com>
On 4/17/24 15:53, Andy Shevchenko wrote:
>> There are already 2 other KUnit tests in `lib/` covering different groups of
>> string functions separately (lib/strscpy_kunit.c, lib/strcat_kunit.c), so
>> this patch just follows this pattern. I believe it makes sense: the tests
>> are separated to cover one specific group of string functions with a similar
>> purpose
>
> We have handful of the string functions, are you going to have a file per
> function? Isn't it way too many?
>
> P.S>
> Having those does not prove it's a correct approach. I would rather expect
> somebody to incorporate those into string_kunit.c.
>
Makes sense. Also, probably having all of them in `string_kunit.c` would
fit better into the KUnit test style guidelines.
I'll merge this strcmp test into `string_kunit.c` in V2 of this patch,
thank you for the review.
--
Kind regards,
Ivan Orlov
prev parent reply other threads:[~2024-04-17 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 13:54 [PATCH] string: Implement KUnit test for str*cmp functions Ivan Orlov
2024-04-17 14:28 ` Andy Shevchenko
2024-04-17 14:46 ` Ivan Orlov
2024-04-17 14:53 ` Andy Shevchenko
2024-04-17 15:12 ` Ivan Orlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f6d22cb-2170-4b80-912a-cfee18381b43@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).