From: Kees Cook <keescook@chromium.org>
To: Fei Li <fei1.li@intel.com>, Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] virt: acrn: replace deprecated strncpy with strscpy
Date: Wed, 24 Apr 2024 16:45:31 -0700 [thread overview]
Message-ID: <171400232813.3283422.11054250337629213107.b4-ty@chromium.org> (raw)
In-Reply-To: <20240320-strncpy-drivers-virt-acrn-ioreq-c-v1-1-db6996770341@google.com>
On Wed, 20 Mar 2024 23:27:09 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We can see that client->name should be NUL-terminated based on its usage
> with a %s C-string format specifier.
> | client->thread = kthread_run(ioreq_task, client, "VM%u-%s",
> | client->vm->vmid, client->name);
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] virt: acrn: replace deprecated strncpy with strscpy
https://git.kernel.org/kees/c/e8a87d0cd048
Take care,
--
Kees Cook
prev parent reply other threads:[~2024-04-24 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 23:27 [PATCH] virt: acrn: replace deprecated strncpy with strscpy Justin Stitt
2024-03-29 4:05 ` Kees Cook
2024-04-24 23:45 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171400232813.3283422.11054250337629213107.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=fei1.li@intel.com \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).