From: Kees Cook <keescook@chromium.org>
To: Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pstore/blk: replace deprecated strncpy with strscpy
Date: Thu, 28 Mar 2024 15:00:19 -0700 [thread overview]
Message-ID: <171166321787.3580825.614329784153739643.b4-ty@chromium.org> (raw)
In-Reply-To: <20240328-strncpy-fs-pstore-blk-c-v1-1-5748cdc22a53@google.com>
On Thu, 28 Mar 2024 20:54:16 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We know that info-device should be NUL-terminated based on its use with
> strlen():
> | static int __init mtdpstore_init(void)
> | {
> | int ret;
> | struct mtdpstore_context *cxt = &oops_cxt;
> | struct pstore_blk_config *info = &cxt->info;
> |
> | ret = pstore_blk_get_config(info);
> | if (unlikely(ret))
> | return ret;
> |
> | if (strlen(info->device) == 0) {
> | pr_err("mtd device must be supplied (device name is empty)\n");
> ...
>
> [...]
Applied to for-next/pstore, thanks!
[1/1] pstore/blk: replace deprecated strncpy with strscpy
https://git.kernel.org/kees/c/80b735d01bbb
Take care,
--
Kees Cook
prev parent reply other threads:[~2024-03-28 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 20:54 [PATCH] pstore/blk: replace deprecated strncpy with strscpy Justin Stitt
2024-03-28 22:00 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171166321787.3580825.614329784153739643.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=gpiccoli@igalia.com \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).