From: Francois Romieu <romieu@fr.zoreil.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>,
linux-hams@vger.kernel.org, Bernard <bernard.f6bvp@gmail.com>,
Bernard Pidoux <f6bvp@free.fr>,
Thomas Osterried <thomas@osterried.de>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v2 net 1/1] rose: check NULL rose_loopback_neigh->loopback
Date: Fri, 26 Aug 2022 02:02:40 +0200 [thread overview]
Message-ID: <YwgNoB2DXdx2+gLI@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <CANn89i+3jZLjy0iYDo78QhQ5STt2X6B2zxX0rY-xOdqmy9WFSA@mail.gmail.com>
Eric Dumazet <edumazet@google.com> :
[...]
> ok but then the original crash/bug reappears....
When the fuzzer runs, the system does not notice that something goes
wrong until rose_find_listener() returns NULL in rose_rx_call_request
whereas Bernard's connect passes this test.
Testing both sk == NULL and !neigh->dev after rose_find_listener may
work but it looks like an ugly bandaid.
Good night.
--
Ueimor
prev parent reply other threads:[~2022-08-26 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 0:02 [PATCH v2 net 1/1] rose: check NULL rose_loopback_neigh->loopback Francois Romieu
2022-08-22 13:30 ` patchwork-bot+netdevbpf
2022-08-25 18:17 ` Eric Dumazet
2022-08-26 0:02 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwgNoB2DXdx2+gLI@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=bernard.f6bvp@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f6bvp@free.fr \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas@osterried.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).