From: Leon Romanovsky <leon@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
Michal Simek <michal.simek@xilinx.com>,
John Linn <john.linn@xilinx.com>, Sadanand M <sadanan@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
Ilya Yanok <yanok@emcraft.com>, Joerg Reuter <jreuter@yaina.de>,
linux-hams@vger.kernel.org
Subject: Re: [PATCH v2 resend 0/4] net: don't call dev_kfree_skb() under spin_lock_irqsave()
Date: Thu, 8 Dec 2022 11:29:04 +0200 [thread overview]
Message-ID: <Y5GuYA/abm1UvUro@unreal> (raw)
In-Reply-To: <20221208032655.1024032-1-yangyingliang@huawei.com>
On Thu, Dec 08, 2022 at 11:26:51AM +0800, Yang Yingliang wrote:
> It is not allowed to call consume_skb() from hardware interrupt context
> or with interrupts being disabled. This patchset replace dev_kfree_skb()
> with dev_consume_skb_irq() under spin_lock_irqsave() in some drivers, or
> move dev_kfree_skb() after spin_unlock_irqrestore().
Like I said it to you already. You MUST explain why dev_consume_skb_irq()
was chosen over dev_kfree_skb_irq().
Thanks
>
> Resend for CC all authors / reviewers of commits under "Fixes:".
>
> v1 -> v2:
> patch #2 Move dev_kfree_skb() after spin_unlock_irqrestore()
>
> Yang Yingliang (4):
> net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave()
> net: ethernet: dnet: don't call dev_kfree_skb() under
> spin_lock_irqsave()
> hamradio: don't call dev_kfree_skb() under spin_lock_irqsave()
> net: amd: lance: don't call dev_kfree_skb() under spin_lock_irqsave()
>
> drivers/net/ethernet/amd/atarilance.c | 2 +-
> drivers/net/ethernet/amd/lance.c | 2 +-
> drivers/net/ethernet/dnet.c | 4 ++--
> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +-
> drivers/net/hamradio/scc.c | 6 +++---
> 5 files changed, 8 insertions(+), 8 deletions(-)
>
> --
> 2.25.1
>
prev parent reply other threads:[~2022-12-08 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 3:26 [PATCH v2 resend 0/4] net: don't call dev_kfree_skb() under spin_lock_irqsave() Yang Yingliang
2022-12-08 3:26 ` [PATCH v2 resend 3/4] hamradio: " Yang Yingliang
2022-12-08 9:29 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5GuYA/abm1UvUro@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.linn@xilinx.com \
--cc=jreuter@yaina.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hams@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sadanan@xilinx.com \
--cc=yangyingliang@huawei.com \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).