From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
zhanghongchen <zhanghongchen@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
<linux-gpio@vger.kernel.org>, <imx@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 4/5] pinctrl: qcom: sm7150: fix module autoloading
Date: Thu, 11 Apr 2024 08:39:52 -0700 [thread overview]
Message-ID: <ZhgESEq+9jRuta2B@hu-bjorande-lv.qualcomm.com> (raw)
In-Reply-To: <20240410170150.248428-4-krzk@kernel.org>
On Wed, Apr 10, 2024 at 07:01:49PM +0200, Krzysztof Kozlowski wrote:
> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
> based on the alias from of_device_id table. Pin controllers are
> considered core components, so usually they are built-in, however these
> can be built and used as modules on some generic kernel.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-sm7150.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm7150.c b/drivers/pinctrl/qcom/pinctrl-sm7150.c
> index c25357ca1963..c542f9bc6bcd 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm7150.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm7150.c
> @@ -1246,6 +1246,7 @@ static const struct of_device_id sm7150_tlmm_of_match[] = {
> { .compatible = "qcom,sm7150-tlmm", },
> { },
> };
> +MODULE_DEVICE_TABLE(of, sm7150_tlmm_of_match);
>
> static struct platform_driver sm7150_tlmm_driver = {
> .driver = {
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-04-11 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 17:01 [PATCH 1/5] pinctrl: freescale: imx8ulp: fix module autoloading Krzysztof Kozlowski
2024-04-10 17:01 ` [PATCH 2/5] pinctrl: mediatek: " Krzysztof Kozlowski
2024-04-10 17:01 ` [PATCH 3/5] pinctrl: loongson2: " Krzysztof Kozlowski
2024-04-10 17:01 ` [PATCH 4/5] pinctrl: qcom: sm7150: " Krzysztof Kozlowski
2024-04-10 17:51 ` Konrad Dybcio
2024-04-11 15:39 ` Bjorn Andersson [this message]
2024-04-10 17:01 ` [PATCH 5/5] pinctrl: realtek: " Krzysztof Kozlowski
2024-04-10 23:36 ` Fabio Estevam
2024-04-11 6:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhgESEq+9jRuta2B@hu-bjorande-lv.qualcomm.com \
--to=quic_bjorande@quicinc.com \
--cc=aisheng.dong@nxp.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sean.wang@kernel.org \
--cc=shawnguo@kernel.org \
--cc=zhanghongchen@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).