From: Xu Yang <xu.yang_2@nxp.com>
To: Christoph Hellwig <hch@lst.de>
Cc: brauner@kernel.org, djwong@kernel.org, willy@infradead.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jun.li@nxp.com
Subject: Re: [PATCH v3] iomap: avoid redundant fault_in_iov_iter_readable() judgement when use larger chunks
Date: Tue, 21 May 2024 09:57:35 +0800 [thread overview]
Message-ID: <20240521015735.bcgc7brwb334zybx@hippo> (raw)
In-Reply-To: <20240520152917.GA485@lst.de>
On Mon, May 20, 2024 at 05:29:17PM +0200, Christoph Hellwig wrote:
> This looks generally good. But a few nitpicks:
>
> - please split the mapping_max_folio_size addition into a separate
> well-documented helper instead of merging it into the iomap change.
Okay. Will do that in v4.
> - judgment is a really weird term for code. Here is a subject I came
> up with, which might not be perfect:
>
> "iomap: fault in smaller chunks for non-large folio mappings"
>
A better choice for me.
Thanks,
Xu Yang
prev parent reply other threads:[~2024-05-21 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 10:55 [PATCH v3] iomap: avoid redundant fault_in_iov_iter_readable() judgement when use larger chunks Xu Yang
2024-05-20 15:08 ` Darrick J. Wong
2024-05-21 1:51 ` Xu Yang
2024-05-20 15:29 ` Christoph Hellwig
2024-05-21 1:57 ` Xu Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521015735.bcgc7brwb334zybx@hippo \
--to=xu.yang_2@nxp.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jun.li@nxp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).